mirror of
https://github.com/git/git
synced 2024-10-30 14:03:28 +00:00
eab4ac6a23
Fix an edge case that was missed when the dir_clear() call was added ineceba53214(dir: fix problematic API to avoid memory leaks, 2020-08-18), we need to also clean up when we're about to exit with non-zero. That commit says, on the topic of the dir_clear() API and UNLEAK(): [...]two of them clearly thought about leaks since they had an UNLEAK(dir) directive, which to me suggests that the method to free the data was too unclear. I think that0e5bba53af(add UNLEAK annotation for reducing leak false positives, 2017-09-08) which added the UNLEAK() makes it clear that that wasn't the case, rather it was the desire to avoid the complexity of freeing the memory at the end of the program. This does add a bit of complexity, but I think it's worth it to just fix these leaks when it's easy in built-ins. It allows them to serve as canaries for underlying APIs that shouldn't be leaking, it encourages us to make those freeing APIs nicer for all their users, and it prevents other leaking regressions by being able to mark the entire test as TEST_PASSES_SANITIZE_LEAK=true. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
47 lines
854 B
Bash
Executable file
47 lines
854 B
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='reset --hard unmerged'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
|
|
mkdir before later &&
|
|
>before/1 &&
|
|
>before/2 &&
|
|
>hello &&
|
|
>later/3 &&
|
|
git add before hello later &&
|
|
git commit -m world &&
|
|
|
|
H=$(git rev-parse :hello) &&
|
|
git rm --cached hello &&
|
|
echo "100644 $H 2 hello" | git update-index --index-info &&
|
|
|
|
rm -f hello &&
|
|
mkdir -p hello &&
|
|
>hello/world &&
|
|
test "$(git ls-files -o)" = hello/world
|
|
|
|
'
|
|
|
|
test_expect_success 'reset --hard should restore unmerged ones' '
|
|
|
|
git reset --hard &&
|
|
git ls-files --error-unmatch before/1 before/2 hello later/3 &&
|
|
test -f hello
|
|
|
|
'
|
|
|
|
test_expect_success 'reset --hard did not corrupt index or cache-tree' '
|
|
|
|
T=$(git write-tree) &&
|
|
rm -f .git/index &&
|
|
git add before hello later &&
|
|
U=$(git write-tree) &&
|
|
test "$T" = "$U"
|
|
|
|
'
|
|
|
|
test_done
|