1
0
mirror of https://github.com/git/git synced 2024-07-02 15:48:44 +00:00
git/reftable
Patrick Steinhardt 66f892bb07 reftable: cast away constness when assigning constants to records
The reftable records are used in multiple ways throughout the reftable
library. In many of those cases they merely act as input to a function
without getting modified by it at all. Most importantly, this happens
when writing records and when querying for records.

We rely on this in our tests and thus assign string constants to those
fields, which is about to generate warnings as those fields are of type
`char *`. While we could go through the process and instead allocate
those strings in all of our tests, this feels quite unnecessary.

Instead, add casts to `char *` for all of those strings. As this is part
of our tests, this also nicely serves as a demonstration that nothing
writes or frees those string constants, which would otherwise lead to
segfaults.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2024-06-07 10:30:49 -07:00
..
basics_test.c global: improve const correctness when assigning string constants 2024-06-07 10:30:48 -07:00
basics.c global: improve const correctness when assigning string constants 2024-06-07 10:30:48 -07:00
basics.h global: improve const correctness when assigning string constants 2024-06-07 10:30:48 -07:00
block_test.c reftable: cast away constness when assigning constants to records 2024-06-07 10:30:49 -07:00
block.c Merge branch 'ps/reftable-write-optim' 2024-05-08 10:18:43 -07:00
block.h Merge branch 'ps/reftable-write-optim' 2024-05-08 10:18:43 -07:00
blocksource.c reftable: introduce macros to allocate arrays 2024-02-06 12:10:08 -08:00
blocksource.h reftable: add blocksource, an abstraction for random access reads 2021-10-08 10:45:48 -07:00
constants.h reftable: (de)serialization for the polymorphic record type. 2021-10-08 10:45:48 -07:00
dump.c treewide: remove unnecessary includes in source files 2023-12-26 12:04:31 -08:00
error.c Merge branch 'ps/reftable-write-optim' 2024-05-08 10:18:43 -07:00
generic.c treewide: remove unnecessary includes in source files 2023-12-26 12:04:31 -08:00
generic.h reftable: generic interface to tables 2021-10-08 10:45:48 -07:00
iter.c reftable/block: rename block_reader_start() 2024-04-15 10:36:09 -07:00
iter.h reftable/merged: remove unnecessary null check for subiters 2024-03-04 10:19:39 -08:00
LICENSE
merged_test.c reftable: cast away constness when assigning constants to records 2024-06-07 10:30:49 -07:00
merged.c reftable/merged: avoid duplicate pqueue emptiness check 2024-03-04 10:19:40 -08:00
merged.h reftable/merged: make merged_iter structure private 2024-03-04 10:19:30 -08:00
pq_test.c reftable/merged: make subiters own their records 2024-03-04 10:19:39 -08:00
pq.c reftable: allow inlining of a few functions 2024-03-04 10:19:49 -08:00
pq.h reftable: allow inlining of a few functions 2024-03-04 10:19:49 -08:00
publicbasics.c reftable: introduce macros to allocate arrays 2024-02-06 12:10:08 -08:00
reader.c reftable/block: reuse zstream state on inflation 2024-04-15 10:36:09 -07:00
reader.h reftable: read reftable files 2021-10-08 10:45:48 -07:00
readwrite_test.c reftable: cast away constness when assigning constants to records 2024-06-07 10:30:49 -07:00
record_test.c reftable/record: use scratch buffer when decoding records 2024-03-05 09:10:06 -08:00
record.c global: improve const correctness when assigning string constants 2024-06-07 10:30:48 -07:00
record.h reftable/record: extract function to decode key lengths 2024-04-03 09:16:50 -07:00
reftable-blocksource.h reftable: add blocksource, an abstraction for random access reads 2021-10-08 10:45:48 -07:00
reftable-error.h Merge branch 'ps/reftable-write-optim' 2024-05-08 10:18:43 -07:00
reftable-generic.h reftable: generic interface to tables 2021-10-08 10:45:48 -07:00
reftable-iterator.h reftable: generic interface to tables 2021-10-08 10:45:48 -07:00
reftable-malloc.h reftable: utility functions 2021-10-08 10:45:48 -07:00
reftable-merged.h reftable/stack: use size_t to track stack length 2024-02-06 12:10:08 -08:00
reftable-reader.h reftable: read reftable files 2021-10-08 10:45:48 -07:00
reftable-record.h reftable/record: reuse message when decoding log records 2024-03-05 09:10:06 -08:00
reftable-stack.h reftable: implement stack, a mutable database of reftable files. 2021-10-08 10:45:48 -07:00
reftable-tests.h reftable: remove name checks 2024-04-08 17:01:41 -07:00
reftable-writer.h Merge branch 'ps/reftable-write-optim' 2024-05-08 10:18:43 -07:00
stack_test.c reftable: cast away constness when assigning constants to records 2024-06-07 10:30:49 -07:00
stack.c global: improve const correctness when assigning string constants 2024-06-07 10:30:48 -07:00
stack.h reftable/stack: use geometric table compaction 2024-04-08 12:11:10 -07:00
system.h reftable/stack: register lockfiles during compaction 2024-03-07 12:34:13 -08:00
test_framework.c reftable: honor core.fsync 2024-01-23 13:45:27 -08:00
test_framework.h reftable: honor core.fsync 2024-01-23 13:45:27 -08:00
tree_test.c treewide: remove unnecessary includes in source files 2023-12-26 12:04:31 -08:00
tree.c reftable: introduce macros to allocate arrays 2024-02-06 12:10:08 -08:00
tree.h reftable: a generic binary tree implementation 2021-10-08 10:45:48 -07:00
writer.c reftable/writer: reset last_key instead of releasing it 2024-04-08 17:01:41 -07:00
writer.h reftable: honor core.fsync 2024-01-23 13:45:27 -08:00