mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
e75d2f7f73
Extend the the release_revisions() function so that it frees the "filter" in the "struct rev_info". This in combination with a preceding change to free "cmdline" means that we can mark another set of tests as passing under "TEST_PASSES_SANITIZE_LEAK=true". The "filter" member was added recently inffaa137f64(revision: put object filter into struct rev_info, 2022-03-09), and this fixes leaks intruded in the subsequent leak7940941de1(pack-objects: use rev.filter when possible, 2022-03-09) and105c6f14ad(bundle: parse filter capability, 2022-03-09). The "builtin/pack-objects.c" leak in7940941de1was effectively with us already, but the variable was referred to by a "static" file-scoped variable. The "bundle.c " leak in105c6f14adwas newly introduced with the new "filter" feature for bundles. The "t5600-clone-fail-cleanup.sh" change here to add "TEST_PASSES_SANITIZE_LEAK=true" is one of the cases where run-command.c in not carrying the abort() exit code upwards would have had that test passing before, but now it *actually* passes[1]. We should fix the lack of 1=1 mapping of SANITIZE=leak testing to actual leaks some other time, but it's an existing edge case, let's just mark the really-passing test as passing for now. 1. https://lore.kernel.org/git/220303.86fsnz5o9w.gmgdl@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
62 lines
1.8 KiB
Bash
Executable file
62 lines
1.8 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2006 Shawn Pearce
|
|
#
|
|
|
|
test_description='mmap sliding window tests'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success \
|
|
'setup' \
|
|
'rm -f .git/index* &&
|
|
for i in a b c
|
|
do
|
|
echo $i >$i &&
|
|
test-tool genrandom "$i" 32768 >>$i &&
|
|
git update-index --add $i || return 1
|
|
done &&
|
|
echo d >d && cat c >>d && git update-index --add d &&
|
|
tree=$(git write-tree) &&
|
|
commit1=$(git commit-tree $tree </dev/null) &&
|
|
git update-ref HEAD $commit1 &&
|
|
git repack -a -d &&
|
|
test "$(git count-objects)" = "0 objects, 0 kilobytes" &&
|
|
pack1=$(ls .git/objects/pack/*.pack) &&
|
|
test -f "$pack1"'
|
|
|
|
test_expect_success \
|
|
'verify-pack -v, defaults' \
|
|
'git verify-pack -v "$pack1"'
|
|
|
|
test_expect_success \
|
|
'verify-pack -v, packedGitWindowSize == 1 page' \
|
|
'git config core.packedGitWindowSize 512 &&
|
|
git verify-pack -v "$pack1"'
|
|
|
|
test_expect_success \
|
|
'verify-pack -v, packedGit{WindowSize,Limit} == 1 page' \
|
|
'git config core.packedGitWindowSize 512 &&
|
|
git config core.packedGitLimit 512 &&
|
|
git verify-pack -v "$pack1"'
|
|
|
|
test_expect_success \
|
|
'repack -a -d, packedGit{WindowSize,Limit} == 1 page' \
|
|
'git config core.packedGitWindowSize 512 &&
|
|
git config core.packedGitLimit 512 &&
|
|
commit2=$(git commit-tree $tree -p $commit1 </dev/null) &&
|
|
git update-ref HEAD $commit2 &&
|
|
git repack -a -d &&
|
|
test "$(git count-objects)" = "0 objects, 0 kilobytes" &&
|
|
pack2=$(ls .git/objects/pack/*.pack) &&
|
|
test -f "$pack2" &&
|
|
test "$pack1" \!= "$pack2"'
|
|
|
|
test_expect_success \
|
|
'verify-pack -v, defaults' \
|
|
'git config --unset core.packedGitWindowSize &&
|
|
git config --unset core.packedGitLimit &&
|
|
git verify-pack -v "$pack2"'
|
|
|
|
test_done
|