mirror of
https://github.com/git/git
synced 2024-08-25 10:45:59 +00:00
480f062cec
Using eval causes problems when the URL contains an appropriately escaped ampersand (\&). Dropping eval from the built-in browser invocation avoids the problem. Helped-by: Jeff King <peff@peff.net> (test case) Signed-off-by: Chris Packham <judge.packham@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
67 lines
1.5 KiB
Bash
Executable file
67 lines
1.5 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
|
|
test_description='git web--browse basic tests
|
|
|
|
This test checks that git web--browse can handle various valid URLs.'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success \
|
|
'URL with an ampersand in it' '
|
|
echo http://example.com/foo\&bar >expect &&
|
|
git config browser.custom.cmd echo &&
|
|
git web--browse --browser=custom \
|
|
http://example.com/foo\&bar >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success \
|
|
'URL with a semi-colon in it' '
|
|
echo http://example.com/foo\;bar >expect &&
|
|
git config browser.custom.cmd echo &&
|
|
git web--browse --browser=custom \
|
|
http://example.com/foo\;bar >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success \
|
|
'URL with a hash in it' '
|
|
echo http://example.com/foo#bar >expect &&
|
|
git config browser.custom.cmd echo &&
|
|
git web--browse --browser=custom \
|
|
http://example.com/foo#bar >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success \
|
|
'browser paths are properly quoted' '
|
|
echo fake: http://example.com/foo >expect &&
|
|
cat >"fake browser" <<-\EOF &&
|
|
#!/bin/sh
|
|
echo fake: "$@"
|
|
EOF
|
|
chmod +x "fake browser" &&
|
|
git config browser.w3m.path "`pwd`/fake browser" &&
|
|
git web--browse --browser=w3m \
|
|
http://example.com/foo >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success \
|
|
'browser command allows arbitrary shell code' '
|
|
echo "arg: http://example.com/foo" >expect &&
|
|
git config browser.custom.cmd "
|
|
f() {
|
|
for i in \"\$@\"; do
|
|
echo arg: \$i
|
|
done
|
|
}
|
|
f" &&
|
|
git web--browse --browser=custom \
|
|
http://example.com/foo >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|