mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
13019d4136
This patch fixes memory leaks in parse_object() and related functions; these leaks were very noticeable when running git-fsck-cache. Signed-off-by: Sergey Vlasov <vsu@altlinux.ru> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
43 lines
1.1 KiB
C
43 lines
1.1 KiB
C
#include "blob.h"
|
|
#include "cache.h"
|
|
#include <stdlib.h>
|
|
|
|
const char *blob_type = "blob";
|
|
|
|
struct blob *lookup_blob(unsigned char *sha1)
|
|
{
|
|
struct object *obj = lookup_object(sha1);
|
|
if (!obj) {
|
|
struct blob *ret = xmalloc(sizeof(struct blob));
|
|
memset(ret, 0, sizeof(struct blob));
|
|
created_object(sha1, &ret->object);
|
|
ret->object.type = blob_type;
|
|
return ret;
|
|
}
|
|
if (obj->type != blob_type) {
|
|
error("Object %s is a %s, not a blob",
|
|
sha1_to_hex(sha1), obj->type);
|
|
return NULL;
|
|
}
|
|
return (struct blob *) obj;
|
|
}
|
|
|
|
int parse_blob(struct blob *item)
|
|
{
|
|
char type[20];
|
|
void *buffer;
|
|
unsigned long size;
|
|
if (item->object.parsed)
|
|
return 0;
|
|
item->object.parsed = 1;
|
|
buffer = read_sha1_file(item->object.sha1, type, &size);
|
|
if (!buffer)
|
|
return error("Could not read %s",
|
|
sha1_to_hex(item->object.sha1));
|
|
free(buffer);
|
|
if (strcmp(type, blob_type))
|
|
return error("Object %s not a blob",
|
|
sha1_to_hex(item->object.sha1));
|
|
return 0;
|
|
}
|