mirror of
https://github.com/git/git
synced 2024-10-30 14:03:28 +00:00
8b9a42bf48
When we originally added the fuzz tests in5e47215080(fuzz: add basic fuzz testing target., 2018-10-12), we went to some trouble to create a Makefile rule that allowed linking the fuzz executables without pulling in common-main.o. This was necessary to prevent the fuzzing-engine-provided main() from clashing with Git's main(). However, since19d75948ef(common-main.c: move non-trace2 exit() behavior out of trace2.c, 2022-06-02), it has been necessary to link common-main.o due to moving the common_exit() function to that file. Ævar suggested a set of compiler flags to allow this in [1], but this was never reflected in the Makefile. Since we now must include common-main.o, there's no reason to pick and choose a subset of object files to link, so simplify the Makefile rule for the fuzzer executables to just use libgit.a. While we're at it, include the necessary linker flag to allow multiple definitions directly in the Makefile rule, rather than requiring it to be passed on the command-line each time. This means the Makefile rule as written is now more compiler-specific, but this was already the case for the fuzzers themselves anyway. [1] https://lore.kernel.org/git/220607.8635ggupws.gmgdl@evledraar.gmail.com/ Signed-off-by: Josh Steadmon <steadmon@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
14 lines
474 B
C
14 lines
474 B
C
#include "git-compat-util.h"
|
|
|
|
/*
|
|
* When linking the fuzzers, we link against common-main.o to pick up some
|
|
* symbols. However, even though we ignore common-main:main(), we still need to
|
|
* provide all the symbols it references. In the fuzzers' case, we need to
|
|
* provide a dummy cmd_main() for the linker to be happy. It will never be
|
|
* executed.
|
|
*/
|
|
|
|
int cmd_main(int argc, const char **argv) {
|
|
BUG("We should not execute cmd_main() from a fuzz target");
|
|
return 1;
|
|
}
|