mirror of
https://github.com/git/git
synced 2024-08-24 18:26:02 +00:00
41ac414ea2
Originally, test_expect_failure was designed to be the opposite
of test_expect_success, but this was a bad decision. Most tests
run a series of commands that leads to the single command that
needs to be tested, like this:
test_expect_{success,failure} 'test title' '
setup1 &&
setup2 &&
setup3 &&
what is to be tested
'
And expecting a failure exit from the whole sequence misses the
point of writing tests. Your setup$N that are supposed to
succeed may have failed without even reaching what you are
trying to test. The only valid use of test_expect_failure is to
check a trivial single command that is expected to fail, which
is a minority in tests of Porcelain-ish commands.
This large-ish patch rewrites all uses of test_expect_failure to
use test_expect_success and rewrites the condition of what is
tested, like this:
test_expect_success 'test title' '
setup1 &&
setup2 &&
setup3 &&
! this command should fail
'
test_expect_failure is redefined to serve as a reminder that
that test *should* succeed but due to a known breakage in git it
currently does not pass. So if git-foo command should create a
file 'bar' but you discovered a bug that it doesn't, you can
write a test like this:
test_expect_failure 'git-foo should create bar' '
rm -f bar &&
git foo &&
test -f bar
'
This construct acts similar to test_expect_success, but instead
of reporting "ok/FAIL" like test_expect_success does, the
outcome is reported as "FIXED/still broken".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
43 lines
1.1 KiB
Bash
Executable file
43 lines
1.1 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (C) 2006 Carl D. Worth <cworth@cworth.org>
|
|
#
|
|
|
|
test_description='test git-clone to cleanup after failure
|
|
|
|
This test covers the fact that if git-clone fails, it should remove
|
|
the directory it created, to avoid the user having to manually
|
|
remove the directory before attempting a clone again.'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success \
|
|
'clone of non-existent source should fail' \
|
|
'! git-clone foo bar'
|
|
|
|
test_expect_success \
|
|
'failed clone should not leave a directory' \
|
|
'! test -d bar'
|
|
|
|
# Need a repo to clone
|
|
test_create_repo foo
|
|
|
|
# clone doesn't like it if there is no HEAD. Is that a bug?
|
|
(cd foo && touch file && git add file && git commit -m 'add file' >/dev/null 2>&1)
|
|
|
|
# source repository given to git-clone should be relative to the
|
|
# current path not to the target dir
|
|
test_expect_success \
|
|
'clone of non-existent (relative to $PWD) source should fail' \
|
|
'! git-clone ../foo baz'
|
|
|
|
test_expect_success \
|
|
'clone should work now that source exists' \
|
|
'git-clone foo bar'
|
|
|
|
test_expect_success \
|
|
'successful clone must leave the directory' \
|
|
'cd bar'
|
|
|
|
test_done
|