mirror of
https://github.com/git/git
synced 2024-08-28 12:09:19 +00:00
![John Cai](/assets/img/avatar_default.png)
When format is passed into --batch, --batch-check, --batch-command, the format gets expanded. When nothing is passed in, the default format is set and the expand_format() gets called. We can save on these cycles by hardcoding how to print the information when nothing is passed as the format, or when the default format is passed. There is no need for the fully expanded format with the default. Since batch_object_write() happens on every object provided in batch mode, we get a nice performance improvement. git rev-list --all > /tmp/all-obj.txt git cat-file --batch-check </tmp/all-obj.txt with HEAD^: Time (mean ± σ): 57.6 ms ± 1.7 ms [User: 51.5 ms, System: 6.2 ms] Range (min … max): 54.6 ms … 64.7 ms 50 runs with HEAD: Time (mean ± σ): 49.8 ms ± 1.7 ms [User: 42.6 ms, System: 7.3 ms] Range (min … max): 46.9 ms … 55.9 ms 56 runs If nothing is provided as a format argument, or if the default format is passed, skip expanding of the format and print the object info with a default format. See https://lore.kernel.org/git/87eecf8ork.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: John Cai <johncai86@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
13 lines
205 B
Bash
Executable file
13 lines
205 B
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='Tests listing object info performance'
|
|
. ./perf-lib.sh
|
|
|
|
test_perf_large_repo
|
|
|
|
test_perf 'cat-file --batch-check' '
|
|
git cat-file --batch-all-objects --batch-check
|
|
'
|
|
|
|
test_done
|