mirror of
https://github.com/git/git
synced 2024-08-23 18:00:25 +00:00
![Ævar Arnfjörð Bjarmason](/assets/img/avatar_default.png)
The "checkout" command is one of the main sources of leaks in the test
suite, let's fix the common ones by not leaking from the "struct
branch_info".
Doing this is rather straightforward, albeit verbose, we need to
xstrdup() constant strings going into the struct, and free() the ones
we clobber as we go along.
This also means that we can delete previous partial leak fixes in this
area, i.e. the "path_to_free" accounting added by 96ec7b1e70
(Convert
resolve_ref+xstrdup to new resolve_refdup function, 2011-12-13).
There was some discussion about whether "we should retain the "const
char *" here and cast at free() time, or have it be a "char *". Since
this is not a public API with any sort of API boundary let's use
"char *", as is already being done for the "refname" member of the
same struct.
The tests to mark as passing were found with:
rm .prove; GIT_SKIP_TESTS=t0027 prove -j8 --state=save t[0-9]*.sh :: --immediate
# apply & compile this change
prove -j8 --state=failed :: --immediate
I.e. the ones that were newly passing when the --state=failed command
was run. I left out "t3040-subprojects-basic.sh" and
"t4131-apply-fake-ancestor.sh" to to optimization-level related
differences similar to the ones noted in[1], except that these would
be something the current 'linux-leaks' job would run into.
1. https://lore.kernel.org/git/cover-v3-0.6-00000000000-20211022T175227Z-avarab@gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
176 lines
4.8 KiB
Bash
Executable file
176 lines
4.8 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2009 Erick Mattos
|
|
#
|
|
|
|
test_description='commit tests of various authorhip options. '
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
author_header () {
|
|
git cat-file commit "$1" |
|
|
sed -n -e '/^$/q' -e '/^author /p'
|
|
}
|
|
|
|
message_body () {
|
|
git cat-file commit "$1" |
|
|
sed -e '1,/^$/d'
|
|
}
|
|
|
|
test_expect_success '-C option copies authorship and message' '
|
|
test_commit --author Frigate\ \<flying@over.world\> \
|
|
"Initial Commit" foo Initial Initial &&
|
|
echo "Test 1" >>foo &&
|
|
test_tick &&
|
|
git commit -a -C Initial &&
|
|
author_header Initial >expect &&
|
|
author_header HEAD >actual &&
|
|
test_cmp expect actual &&
|
|
|
|
message_body Initial >expect &&
|
|
message_body HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success '-C option copies only the message with --reset-author' '
|
|
echo "Test 2" >>foo &&
|
|
test_tick &&
|
|
git commit -a -C Initial --reset-author &&
|
|
echo "author $GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL> $GIT_AUTHOR_DATE" >expect &&
|
|
author_header HEAD >actual &&
|
|
test_cmp expect actual &&
|
|
|
|
message_body Initial >expect &&
|
|
message_body HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success '-c option copies authorship and message' '
|
|
echo "Test 3" >>foo &&
|
|
test_tick &&
|
|
EDITOR=: VISUAL=: git commit -a -c Initial &&
|
|
author_header Initial >expect &&
|
|
author_header HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success '-c option copies only the message with --reset-author' '
|
|
echo "Test 4" >>foo &&
|
|
test_tick &&
|
|
EDITOR=: VISUAL=: git commit -a -c Initial --reset-author &&
|
|
echo "author $GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL> $GIT_AUTHOR_DATE" >expect &&
|
|
author_header HEAD >actual &&
|
|
test_cmp expect actual &&
|
|
|
|
message_body Initial >expect &&
|
|
message_body HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success '--amend option copies authorship' '
|
|
git checkout Initial &&
|
|
echo "Test 5" >>foo &&
|
|
test_tick &&
|
|
git commit -a --amend -m "amend test" &&
|
|
author_header Initial >expect &&
|
|
author_header HEAD >actual &&
|
|
test_cmp expect actual &&
|
|
|
|
echo "amend test" >expect &&
|
|
message_body HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
sha1_file() {
|
|
echo "$*" | sed "s#..#.git/objects/&/#"
|
|
}
|
|
remove_object() {
|
|
rm -f $(sha1_file "$*")
|
|
}
|
|
|
|
test_expect_success '--amend option with empty author' '
|
|
git cat-file commit Initial >tmp &&
|
|
sed "s/author [^<]* </author </" tmp >empty-author &&
|
|
sha=$(git hash-object -t commit -w empty-author) &&
|
|
test_when_finished "remove_object $sha" &&
|
|
git checkout $sha &&
|
|
test_when_finished "git checkout Initial" &&
|
|
echo "Empty author test" >>foo &&
|
|
test_tick &&
|
|
test_must_fail git commit -a -m "empty author" --amend 2>err &&
|
|
test_i18ngrep "empty ident" err
|
|
'
|
|
|
|
test_expect_success '--amend option with missing author' '
|
|
git cat-file commit Initial >tmp &&
|
|
sed "s/author [^<]* </author </" tmp >malformed &&
|
|
sha=$(git hash-object -t commit -w malformed) &&
|
|
test_when_finished "remove_object $sha" &&
|
|
git checkout $sha &&
|
|
test_when_finished "git checkout Initial" &&
|
|
echo "Missing author test" >>foo &&
|
|
test_tick &&
|
|
test_must_fail git commit -a -m "malformed author" --amend 2>err &&
|
|
test_i18ngrep "empty ident" err
|
|
'
|
|
|
|
test_expect_success '--reset-author makes the commit ours even with --amend option' '
|
|
git checkout Initial &&
|
|
echo "Test 6" >>foo &&
|
|
test_tick &&
|
|
git commit -a --reset-author -m "Changed again" --amend &&
|
|
echo "author $GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL> $GIT_AUTHOR_DATE" >expect &&
|
|
author_header HEAD >actual &&
|
|
test_cmp expect actual &&
|
|
|
|
echo "Changed again" >expect &&
|
|
message_body HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success '--reset-author and --author are mutually exclusive' '
|
|
git checkout Initial &&
|
|
echo "Test 7" >>foo &&
|
|
test_tick &&
|
|
test_must_fail git commit -a --reset-author --author="Xyzzy <frotz@nitfol.xz>"
|
|
'
|
|
|
|
test_expect_success '--reset-author should be rejected without -c/-C/--amend' '
|
|
git checkout Initial &&
|
|
echo "Test 7" >>foo &&
|
|
test_tick &&
|
|
test_must_fail git commit -a --reset-author -m done
|
|
'
|
|
|
|
test_expect_success 'commit respects CHERRY_PICK_HEAD and MERGE_MSG' '
|
|
echo "cherry-pick 1a" >>foo &&
|
|
test_tick &&
|
|
git commit -am "cherry-pick 1" --author="Cherry <cherry@pick.er>" &&
|
|
git tag cherry-pick-head &&
|
|
git update-ref CHERRY_PICK_HEAD $(git rev-parse cherry-pick-head) &&
|
|
echo "This is a MERGE_MSG" >.git/MERGE_MSG &&
|
|
echo "cherry-pick 1b" >>foo &&
|
|
test_tick &&
|
|
git commit -a &&
|
|
author_header cherry-pick-head >expect &&
|
|
author_header HEAD >actual &&
|
|
test_cmp expect actual &&
|
|
|
|
echo "This is a MERGE_MSG" >expect &&
|
|
message_body HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success '--reset-author with CHERRY_PICK_HEAD' '
|
|
git update-ref CHERRY_PICK_HEAD $(git rev-parse cherry-pick-head) &&
|
|
echo "cherry-pick 2" >>foo &&
|
|
test_tick &&
|
|
git commit -am "cherry-pick 2" --reset-author &&
|
|
echo "author $GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL> $GIT_AUTHOR_DATE" >expect &&
|
|
author_header HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|