mirror of
https://github.com/git/git
synced 2024-09-12 21:04:12 +00:00
926d233035
Fix a memory leak in t/helper/test-oidtree.c, we were not freeing the
"struct strbuf" we used for the stdin input we parsed. This leak has
been here ever since 92d8ed8ac1 (oidtree: a crit-bit tree for
odb_loose_cache, 2021-07-07).
Now that it's fixed we can declare that t0069-oidtree.sh will pass
under GIT_TEST_PASSING_SANITIZE_LEAK=true.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
53 lines
1.3 KiB
C
53 lines
1.3 KiB
C
#include "test-tool.h"
|
|
#include "cache.h"
|
|
#include "oidtree.h"
|
|
|
|
static enum cb_next print_oid(const struct object_id *oid, void *data)
|
|
{
|
|
puts(oid_to_hex(oid));
|
|
return CB_CONTINUE;
|
|
}
|
|
|
|
int cmd__oidtree(int argc, const char **argv)
|
|
{
|
|
struct oidtree ot;
|
|
struct strbuf line = STRBUF_INIT;
|
|
int nongit_ok;
|
|
int algo = GIT_HASH_UNKNOWN;
|
|
|
|
oidtree_init(&ot);
|
|
setup_git_directory_gently(&nongit_ok);
|
|
|
|
while (strbuf_getline(&line, stdin) != EOF) {
|
|
const char *arg;
|
|
struct object_id oid;
|
|
|
|
if (skip_prefix(line.buf, "insert ", &arg)) {
|
|
if (get_oid_hex_any(arg, &oid) == GIT_HASH_UNKNOWN)
|
|
die("insert not a hexadecimal oid: %s", arg);
|
|
algo = oid.algo;
|
|
oidtree_insert(&ot, &oid);
|
|
} else if (skip_prefix(line.buf, "contains ", &arg)) {
|
|
if (get_oid_hex(arg, &oid))
|
|
die("contains not a hexadecimal oid: %s", arg);
|
|
printf("%d\n", oidtree_contains(&ot, &oid));
|
|
} else if (skip_prefix(line.buf, "each ", &arg)) {
|
|
char buf[GIT_MAX_HEXSZ + 1] = { '0' };
|
|
memset(&oid, 0, sizeof(oid));
|
|
memcpy(buf, arg, strlen(arg));
|
|
buf[hash_algos[algo].hexsz] = '\0';
|
|
get_oid_hex_any(buf, &oid);
|
|
oid.algo = algo;
|
|
oidtree_each(&ot, &oid, strlen(arg), print_oid, NULL);
|
|
} else if (!strcmp(line.buf, "clear")) {
|
|
oidtree_clear(&ot);
|
|
} else {
|
|
die("unknown command: %s", line.buf);
|
|
}
|
|
}
|
|
|
|
strbuf_release(&line);
|
|
|
|
return 0;
|
|
}
|