mirror of
https://github.com/git/git
synced 2024-08-24 18:26:02 +00:00
![Elia Pinto](/assets/img/avatar_default.png)
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
51 lines
936 B
Bash
Executable file
51 lines
936 B
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='format-patch -s should force MIME encoding as needed'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
|
|
>F &&
|
|
git add F &&
|
|
git commit -m initial &&
|
|
echo new line >F &&
|
|
|
|
test_tick &&
|
|
git commit -m "This adds some lines to F" F
|
|
|
|
'
|
|
|
|
test_expect_success 'format normally' '
|
|
|
|
git format-patch --stdout -1 >output &&
|
|
! grep Content-Type output
|
|
|
|
'
|
|
|
|
test_expect_success 'format with signoff without funny signer name' '
|
|
|
|
git format-patch -s --stdout -1 >output &&
|
|
! grep Content-Type output
|
|
|
|
'
|
|
|
|
test_expect_success 'format with non ASCII signer name' '
|
|
|
|
GIT_COMMITTER_NAME="はまの ふにおう" \
|
|
git format-patch -s --stdout -1 >output &&
|
|
grep Content-Type output
|
|
|
|
'
|
|
|
|
test_expect_success 'attach and signoff do not duplicate mime headers' '
|
|
|
|
GIT_COMMITTER_NAME="はまの ふにおう" \
|
|
git format-patch -s --stdout -1 --attach >output &&
|
|
test $(grep -ci ^MIME-Version: output) = 1
|
|
|
|
'
|
|
|
|
test_done
|
|
|