mirror of
https://github.com/git/git
synced 2024-09-29 21:27:13 +00:00
63ee933383
All the Perforce tests are free of memory leaks. This went unnoticed because most folks do not have p4 and p4d installed on their computers. Consequently, given that the prerequisites for running those tests aren't fulfilled, `TEST_PASSES_SANITIZE_LEAK=check` won't notice that those tests are indeed memory leak free. Mark those tests accordingly. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
64 lines
1.5 KiB
Bash
Executable file
64 lines
1.5 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='git p4 handling of UTF-16 files without BOM'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./lib-git-p4.sh
|
|
|
|
UTF16="\227\000\227\000"
|
|
|
|
test_expect_success 'start p4d' '
|
|
start_p4d
|
|
'
|
|
|
|
test_expect_success 'init depot with UTF-16 encoded file and artificially remove BOM' '
|
|
(
|
|
cd "$cli" &&
|
|
printf "$UTF16" >file1 &&
|
|
p4 add -t utf16 file1 &&
|
|
p4 submit -d "file1"
|
|
) &&
|
|
|
|
(
|
|
cd db &&
|
|
p4d -jc &&
|
|
# P4D automatically adds a BOM. Remove it here to make the file invalid.
|
|
#
|
|
# Note that newer Perforce versions started to store files
|
|
# compressed in directories. The case statement handles both
|
|
# old and new layout.
|
|
case "$(echo depot/file1*)" in
|
|
depot/file1,v)
|
|
sed -e "\$d" depot/file1,v >depot/file1,v.new &&
|
|
mv depot/file1,v.new depot/file1,v &&
|
|
printf "@$UTF16@" >>depot/file1,v;;
|
|
depot/file1,d)
|
|
path="$(echo depot/file1,d/*.gz)" &&
|
|
gunzip -c "$path" >"$path.unzipped" &&
|
|
sed -e "\$d" "$path.unzipped" >"$path.new" &&
|
|
printf "$UTF16" >>"$path.new" &&
|
|
gzip -c "$path.new" >"$path" &&
|
|
rm "$path.unzipped" "$path.new";;
|
|
*)
|
|
BUG "unhandled p4d layout";;
|
|
esac &&
|
|
p4d -jrF checkpoint.1
|
|
)
|
|
'
|
|
|
|
test_expect_success 'clone depot with invalid UTF-16 file in verbose mode' '
|
|
git p4 clone --dest="$git" --verbose //depot &&
|
|
test_when_finished cleanup_git &&
|
|
(
|
|
cd "$git" &&
|
|
printf "$UTF16" >expect &&
|
|
test_cmp_bin expect file1
|
|
)
|
|
'
|
|
|
|
test_expect_failure 'clone depot with invalid UTF-16 file in non-verbose mode' '
|
|
git p4 clone --dest="$git" //depot
|
|
'
|
|
|
|
test_done
|