mirror of
https://github.com/git/git
synced 2024-06-30 22:54:27 +00:00
71a1e94821
The "rev-list" and other commands in the "log" family, being the oldest part of the system, use their own custom argument parsers, and integer values of some options are parsed with atoi(), which allows a non-digit after the number (e.g., "1q") to be silently ignored. As a natural consequence, an argument that does not begin with a digit (e.g., "q") silently becomes zero, too. Switch to use strtol_i() and parse_timestamp() appropriately to catch bogus input. Note that one may naïvely expect that --max-count, --skip, etc., to only take non-negative values, but we must allow them to also take negative values, as an escape hatch to countermand a limit set by an earlier option on the command line; the underlying variables are initialized to (-1) and "--max-count=-1", for example, is a legitimate way to reinitialize the limit. Signed-off-by: Junio C Hamano <gitster@pobox.com>
67 lines
2.2 KiB
Bash
Executable File
67 lines
2.2 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='git rev-list --max-count and --skip test'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup' '
|
|
for n in 1 2 3 4 5 ; do
|
|
echo $n > a &&
|
|
git add a &&
|
|
git commit -m "$n" || return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'no options' '
|
|
test_stdout_line_count = 5 git rev-list HEAD
|
|
'
|
|
|
|
test_expect_success '--max-count' '
|
|
test_must_fail git rev-list --max-count=1q HEAD 2>error &&
|
|
grep "not an integer" error &&
|
|
|
|
test_stdout_line_count = 0 git rev-list HEAD --max-count=0 &&
|
|
test_stdout_line_count = 3 git rev-list HEAD --max-count=3 &&
|
|
test_stdout_line_count = 5 git rev-list HEAD --max-count=5 &&
|
|
test_stdout_line_count = 5 git rev-list HEAD --max-count=10 &&
|
|
test_stdout_line_count = 5 git rev-list HEAD --max-count=-1
|
|
'
|
|
|
|
test_expect_success '--max-count all forms' '
|
|
test_must_fail git rev-list -1q HEAD 2>error &&
|
|
grep "not an integer" error &&
|
|
test_must_fail git rev-list --1 HEAD &&
|
|
test_must_fail git rev-list -n 1q HEAD 2>error &&
|
|
grep "not an integer" error &&
|
|
|
|
test_stdout_line_count = 1 git rev-list HEAD --max-count=1 &&
|
|
test_stdout_line_count = 1 git rev-list HEAD -1 &&
|
|
test_stdout_line_count = 1 git rev-list HEAD -n1 &&
|
|
test_stdout_line_count = 1 git rev-list HEAD -n 1 &&
|
|
test_stdout_line_count = 5 git rev-list HEAD -n -1
|
|
'
|
|
|
|
test_expect_success '--skip' '
|
|
test_must_fail git rev-list --skip 1q HEAD 2>error &&
|
|
grep "not an integer" error &&
|
|
|
|
test_stdout_line_count = 5 git rev-list HEAD --skip=0 &&
|
|
test_stdout_line_count = 2 git rev-list HEAD --skip=3 &&
|
|
test_stdout_line_count = 0 git rev-list HEAD --skip=5 &&
|
|
test_stdout_line_count = 0 git rev-list HEAD --skip=10
|
|
'
|
|
|
|
test_expect_success '--skip --max-count' '
|
|
test_stdout_line_count = 0 git rev-list HEAD --skip=0 --max-count=0 &&
|
|
test_stdout_line_count = 5 git rev-list HEAD --skip=0 --max-count=10 &&
|
|
test_stdout_line_count = 0 git rev-list HEAD --skip=3 --max-count=0 &&
|
|
test_stdout_line_count = 1 git rev-list HEAD --skip=3 --max-count=1 &&
|
|
test_stdout_line_count = 2 git rev-list HEAD --skip=3 --max-count=2 &&
|
|
test_stdout_line_count = 2 git rev-list HEAD --skip=3 --max-count=10 &&
|
|
test_stdout_line_count = 0 git rev-list HEAD --skip=5 --max-count=10 &&
|
|
test_stdout_line_count = 0 git rev-list HEAD --skip=10 --max-count=10
|
|
'
|
|
|
|
test_done
|