mirror of
https://github.com/git/git
synced 2024-11-05 01:58:18 +00:00
f3d33f8cfe
The transfer.unpackLimit configuration variable is documented to be
used only as a fallback value when the more operation-specific
fetch.unpackLimit and receive.unpackLimit variables are not set, but
the implementation had the precedence reversed. Apparently this was
broken since the transfer.unpackLimit was introduced in e28714c5
(Consolidate {receive,fetch}.unpackLimit, 2007-01-24).
Often when documentation and code have diverged for so long, we
prefer to change the documentation instead, to avoid disrupting
users. But doing so would make these weirdly unlike most other
"specific overrides general" config options. And the fact that the
bug has existed for so long without anyone noticing implies to me
that nobody really tries to mix and match them much.
Signed-off-by: Taylor Santiago <taylorsantiago@google.com>
[jc: rewrote the log message, added tests, covered receive-pack as well]
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
86 lines
2 KiB
Bash
Executable file
86 lines
2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='check receive input limits'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
# Let's run tests with different unpack limits: 1 and 10000
|
|
# When the limit is 1, `git receive-pack` will call `git index-pack`.
|
|
# When the limit is 10000, `git receive-pack` will call `git unpack-objects`.
|
|
|
|
validate_store_type () {
|
|
git -C dest count-objects -v >actual &&
|
|
case "$store_type" in
|
|
index)
|
|
grep "^count: 0$" actual ;;
|
|
unpack)
|
|
grep "^packs: 0$" actual ;;
|
|
esac || {
|
|
echo "store_type is $store_type"
|
|
cat actual
|
|
false;
|
|
}
|
|
}
|
|
|
|
test_pack_input_limit () {
|
|
store_type=$1
|
|
|
|
case "$store_type" in
|
|
index) unpack_limit=1 other_limit=10000 ;;
|
|
unpack) unpack_limit=10000 other_limit=1 ;;
|
|
esac
|
|
|
|
test_expect_success 'prepare destination repository' '
|
|
rm -fr dest &&
|
|
git --bare init dest
|
|
'
|
|
|
|
test_expect_success "set unpacklimit to $unpack_limit" '
|
|
git --git-dir=dest config receive.unpacklimit "$unpack_limit"
|
|
'
|
|
|
|
test_expect_success 'setting receive.maxInputSize to 512 rejects push' '
|
|
git --git-dir=dest config receive.maxInputSize 512 &&
|
|
test_must_fail git push dest HEAD
|
|
'
|
|
|
|
test_expect_success 'bumping limit to 4k allows push' '
|
|
git --git-dir=dest config receive.maxInputSize 4k &&
|
|
git push dest HEAD
|
|
'
|
|
|
|
test_expect_success 'prepare destination repository (again)' '
|
|
rm -fr dest &&
|
|
git --bare init dest
|
|
'
|
|
|
|
test_expect_success 'lifting the limit allows push' '
|
|
git --git-dir=dest config receive.maxInputSize 0 &&
|
|
git push dest HEAD
|
|
'
|
|
|
|
test_expect_success 'prepare destination repository (once more)' '
|
|
rm -fr dest &&
|
|
git --bare init dest
|
|
'
|
|
|
|
test_expect_success 'receive trumps transfer' '
|
|
git --git-dir=dest config receive.unpacklimit "$unpack_limit" &&
|
|
git --git-dir=dest config transfer.unpacklimit "$other_limit" &&
|
|
git push dest HEAD &&
|
|
validate_store_type
|
|
'
|
|
|
|
}
|
|
|
|
test_expect_success "create known-size (1024 bytes) commit" '
|
|
test-tool genrandom foo 1024 >one-k &&
|
|
git add one-k &&
|
|
test_commit one-k
|
|
'
|
|
|
|
test_pack_input_limit index
|
|
test_pack_input_limit unpack
|
|
|
|
test_done
|