mirror of
https://github.com/git/git
synced 2024-11-04 16:17:49 +00:00
c576868eaf
The top-level &&-chain checker built into t/test-lib.sh causes tests to
magically exit with code 117 if the &&-chain is broken. However, it has
the shortcoming that the magic does not work within `{...}` groups,
`(...)` subshells, `$(...)` substitutions, or within bodies of compound
statements, such as `if`, `for`, `while`, `case`, etc. `chainlint.sed`
partly fills in the gap by catching broken &&-chains in `(...)`
subshells, but bugs can still lurk behind broken &&-chains in the other
cases.
Fix broken &&-chains in `$(...)` command substitutions in order to
reduce the number of possible lurking bugs.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
55 lines
1.2 KiB
Bash
Executable file
55 lines
1.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='signals work as we expect'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
cat >expect <<EOF
|
|
three
|
|
two
|
|
one
|
|
EOF
|
|
|
|
test_expect_success 'sigchain works' '
|
|
{ test-tool sigchain >actual; ret=$?; } &&
|
|
{
|
|
# Signal death by raise() on Windows acts like exit(3),
|
|
# regardless of the signal number. So we must allow that
|
|
# as well as the normal signal check.
|
|
test_match_signal 15 "$ret" ||
|
|
test "$ret" = 3
|
|
} &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success !MINGW 'signals are propagated using shell convention' '
|
|
# we use exec here to avoid any sub-shell interpretation
|
|
# of the exit code
|
|
git config alias.sigterm "!exec test-tool sigchain" &&
|
|
test_expect_code 143 git sigterm
|
|
'
|
|
|
|
large_git () {
|
|
for i in $(test_seq 1 100)
|
|
do
|
|
git diff --cached --binary || return
|
|
done
|
|
}
|
|
|
|
test_expect_success 'create blob' '
|
|
test-tool genrandom foo 16384 >file &&
|
|
git add file
|
|
'
|
|
|
|
test_expect_success !MINGW 'a constipated git dies with SIGPIPE' '
|
|
OUT=$( ((large_git; echo $? 1>&3) | :) 3>&1 ) &&
|
|
test_match_signal 13 "$OUT"
|
|
'
|
|
|
|
test_expect_success !MINGW 'a constipated git dies with SIGPIPE even if parent ignores it' '
|
|
OUT=$( ((trap "" PIPE && large_git; echo $? 1>&3) | :) 3>&1 ) &&
|
|
test_match_signal 13 "$OUT"
|
|
'
|
|
|
|
test_done
|