mirror of
https://github.com/git/git
synced 2024-11-05 04:53:18 +00:00
e44f15ba3e
The annotations emitted by chainlint to indicate detected problems are overly terse, so much so that developers new to the project -- those who should most benefit from the linting -- may find them baffling. For instance, although the author of chainlint and seasoned Git developers may understand that "?!AMP?!" is an abbreviation of "ampersand" and indicates a break in the &&-chain, this may not be obvious to newcomers. The "?!LOOP?!" case is particularly serious because that terse single word does nothing to convey that the loop body should end with "|| return 1" (or "|| exit 1" in a subshell) to ensure that a failing command in the body aborts the loop immediately. Moreover, unlike &&-chaining which is ubiquitous in Git tests, the "|| return 1" idiom is relatively infrequent, thus may be harder for a newcomer to discover by consulting nearby code. Address these shortcomings by emitting human-readable messages which both explain the problem and give a strong hint about how to correct it. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
19 lines
405 B
Text
19 lines
405 B
Text
2 (
|
|
3 (foo && bar) &&
|
|
4 (foo && bar) |
|
|
5 (foo && bar) >baz &&
|
|
6
|
|
7 (foo; ?!LINT: missing '&&'?! bar) &&
|
|
8 (foo; ?!LINT: missing '&&'?! bar) |
|
|
9 (foo; ?!LINT: missing '&&'?! bar) >baz &&
|
|
10
|
|
11 (foo || exit 1) &&
|
|
12 (foo || exit 1) |
|
|
13 (foo || exit 1) >baz &&
|
|
14
|
|
15 (foo && bar) ?!LINT: missing '&&'?!
|
|
16
|
|
17 (foo && bar; ?!LINT: missing '&&'?! baz) ?!LINT: missing '&&'?!
|
|
18
|
|
19 foobar
|
|
20 )
|