mirror of
https://github.com/git/git
synced 2024-11-04 16:17:49 +00:00
bcd5a4059a
The reftable library does not use the same memory allocation functions as the rest of the Git codebase. Instead, as the reftable library is supposed to be usable as a standalone library without Git, it provides a set of pluggable memory allocators. Compared to `xmalloc()` and friends these allocators are _not_ expected to die when an allocation fails. This design choice is concious, as a library should leave it to its caller to handle any kind of error. While it is very likely that the caller cannot really do much in the case of an out-of-memory situation anyway, we are not the ones to make that decision. Curiously though, we never handle allocation errors even though memory allocation functions are allowed to fail. And as we do not plug in Git's memory allocator via `reftable_set_alloc()` either the consequence is that we'd instead segfault as soon as we run out of memory. While the easy fix would be to wire up `xmalloc()` and friends, it would only fix the usage of the reftable library in Git itself. Other users like libgit2, which is about to revive its efforts to land a backend for reftables, wouldn't be able to benefit from this solution. Instead, we are about to do it the hard way: adapt all allocation sites to perform error checking. Introduce a new error code for out-of-memory errors that we will wire up in subsequent steps. This commit also serves as the motivator for all the remaining steps in this series such that we do not have to repeat the same arguments in every single subsequent commit. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
46 lines
1.1 KiB
C
46 lines
1.1 KiB
C
/*
|
|
Copyright 2020 Google LLC
|
|
|
|
Use of this source code is governed by a BSD-style
|
|
license that can be found in the LICENSE file or at
|
|
https://developers.google.com/open-source/licenses/bsd
|
|
*/
|
|
|
|
#include "system.h"
|
|
#include "reftable-error.h"
|
|
|
|
#include <stdio.h>
|
|
|
|
const char *reftable_error_str(int err)
|
|
{
|
|
static char buf[250];
|
|
switch (err) {
|
|
case REFTABLE_IO_ERROR:
|
|
return "I/O error";
|
|
case REFTABLE_FORMAT_ERROR:
|
|
return "corrupt reftable file";
|
|
case REFTABLE_NOT_EXIST_ERROR:
|
|
return "file does not exist";
|
|
case REFTABLE_LOCK_ERROR:
|
|
return "data is locked";
|
|
case REFTABLE_API_ERROR:
|
|
return "misuse of the reftable API";
|
|
case REFTABLE_ZLIB_ERROR:
|
|
return "zlib failure";
|
|
case REFTABLE_EMPTY_TABLE_ERROR:
|
|
return "wrote empty table";
|
|
case REFTABLE_REFNAME_ERROR:
|
|
return "invalid refname";
|
|
case REFTABLE_ENTRY_TOO_BIG_ERROR:
|
|
return "entry too large";
|
|
case REFTABLE_OUTDATED_ERROR:
|
|
return "data concurrently modified";
|
|
case REFTABLE_OUT_OF_MEMORY_ERROR:
|
|
return "out of memory";
|
|
case -1:
|
|
return "general error";
|
|
default:
|
|
snprintf(buf, sizeof(buf), "unknown error code %d", err);
|
|
return buf;
|
|
}
|
|
}
|