development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-24 18:26:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Audit rev-parse users again.

Browse source 
Some callers to rev-parse were using the output selection flags
inconsistently.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano 2005-08-24 14:31:36 -07:00
parent 4866ccf0f4
commit ff84d327df
5 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
git-bisect-script
View file

@ -58,7 +58,7 @@ bisect_start() {
bisect_bad() { bisect_bad() {
bisect_autostart bisect_autostart
case "$#" in 0 | 1) ;; *) usage ;; esac case "$#" in 0 | 1) ;; *) usage ;; esac
rev=$(git-rev-parse --revs-only --verify --default HEAD "$@") || exit rev=$(git-rev-parse --verify --default HEAD "$@") || exit
echo "$rev" > "$GIT_DIR/refs/bisect/bad" echo "$rev" > "$GIT_DIR/refs/bisect/bad"
bisect_auto_next bisect_auto_next
} }
@ -67,7 +67,7 @@ bisect_good() {
bisect_autostart bisect_autostart
case "$#" in case "$#" in
0) revs=$(git-rev-parse --verify HEAD) || exit ;; 0) revs=$(git-rev-parse --verify HEAD) || exit ;;
*) revs=$(git-rev-parse --revs-only "$@") || exit ;; *) revs=$(git-rev-parse --revs-only --no-flags "$@") || exit ;;
esac esac
for rev in $revs for rev in $revs
do do

2
git-branch-script
View file

@ -25,7 +25,7 @@ case "$#" in
head="$2^0" ;; head="$2^0" ;;
esac esac
branchname="$1" branchname="$1"
rev=$(git-rev-parse --revs-only --verify "$head") || exit rev=$(git-rev-parse --verify "$head") || exit
[ -e "$GIT_DIR/refs/heads/$branchname" ] && die "$branchname already exists" [ -e "$GIT_DIR/refs/heads/$branchname" ] && die "$branchname already exists"

2
git-log-script
View file

@ -1,4 +1,4 @@
#!/bin/sh #!/bin/sh
revs=$(git-rev-parse --revs-only --default HEAD "$@") || exit revs=$(git-rev-parse --revs-only --no-flags --default HEAD "$@") || exit
[ "$revs" ] || die "No HEAD ref" [ "$revs" ] || die "No HEAD ref"
git-rev-list --pretty $(git-rev-parse --default HEAD "$@") | LESS=-S ${PAGER:-less} git-rev-list --pretty $(git-rev-parse --default HEAD "$@") | LESS=-S ${PAGER:-less}

4
git-request-pull-script
View file

@ -19,8 +19,8 @@ head=${3-HEAD}
[ "$revision" ] || usage [ "$revision" ] || usage
[ "$url" ] || usage [ "$url" ] || usage
baserev=`git-rev-parse --verify $revision^0` && baserev=`git-rev-parse --verify "$revision"^0` &&
headrev=`git-rev-parse --verify $head^0` || exit headrev=`git-rev-parse --verify "$head"^0` || exit
echo "The following changes since commit $baserev:" echo "The following changes since commit $baserev:"
git log --max-count=1 --pretty=short "$baserev" | git log --max-count=1 --pretty=short "$baserev" |

2
git-revert-script
View file

@ -10,7 +10,7 @@ case "$status" in
die "Your working tree is dirty; cannot revert a previous patch." ;; die "Your working tree is dirty; cannot revert a previous patch." ;;
esac esac
rev=$(git-rev-parse --no-flags --verify --revs-only "$@") && rev=$(git-rev-parse --verify "$@") &&
commit=$(git-rev-parse --verify "$rev^0") || exit commit=$(git-rev-parse --verify "$rev^0") || exit
if git-diff-tree -R -M -p $commit | git-apply --index && if git-diff-tree -R -M -p $commit | git-apply --index &&
msg=$(git-rev-list --pretty=oneline --max-count=1 $commit) msg=$(git-rev-list --pretty=oneline --max-count=1 $commit)