development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-28 03:59:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fast-import.c: don't try to commit marks file if write failed

Browse source 
We also move the assignment of -1 to the lock file descriptor
up, so that rollback_lock_file() can be called safely after a
possible attempt to fclose(). This matches the contents of
the 'if' statement just above testing success of fdopen().

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Brandon Casey 2008-01-17 10:58:34 -06:00 committed by Junio C Hamano
parent b531394d58
commit fb54abd604
1 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
fast-import.c
View file

@ -1545,19 +1545,27 @@ static void dump_marks(void)
return; return;
} }
dump_marks_helper(f, 0, marks);
if (ferror(f) || fclose(f))
failure |= error("Unable to write marks file %s: %s",
mark_file, strerror(errno));
/* /*
* Since the lock file was fdopen()'ed and then fclose()'ed above, * Since the lock file was fdopen()'ed, it should not be close()'ed.
* assign -1 to the lock file descriptor so that commit_lock_file() * Assign -1 to the lock file descriptor so that commit_lock_file()
* won't try to close() it. * won't try to close() it.
*/ */
mark_lock.fd = -1; mark_lock.fd = -1;
if (commit_lock_file(&mark_lock))
failure |= error("Unable to write commit file %s: %s", dump_marks_helper(f, 0, marks);
if (ferror(f) || fclose(f)) {
rollback_lock_file(&mark_lock);
failure |= error("Unable to write marks file %s: %s",
mark_file, strerror(errno)); mark_file, strerror(errno));
return;
}
if (commit_lock_file(&mark_lock)) {
rollback_lock_file(&mark_lock);
failure |= error("Unable to commit marks file %s: %s",
mark_file, strerror(errno));
return;
}
} }
static int read_next_command(void) static int read_next_command(void)