mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
gitweb: Move generating page title to separate subroutine
get_page_title subroutine is currently used only in git_header_html. Nevertheless refactoring title generation allowed to reduce indent level. It would be used in more than one callsite in the patch adding caching activity indicator to gitweb. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Acked-by: Petr Baudis <pasky@suse.cz> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
7a59745710
commit
efb2d0c5dc
|
@ -3179,24 +3179,30 @@ sub blob_contenttype {
|
|||
## ======================================================================
|
||||
## functions printing HTML: header, footer, error page
|
||||
|
||||
sub get_page_title {
|
||||
my $title = to_utf8($site_name);
|
||||
|
||||
return $title unless (defined $project);
|
||||
$title .= " - " . to_utf8($project);
|
||||
|
||||
return $title unless (defined $action);
|
||||
$title .= "/$action"; # $action is US-ASCII (7bit ASCII)
|
||||
|
||||
return $title unless (defined $file_name);
|
||||
$title .= " - " . esc_path($file_name);
|
||||
if ($action eq "tree" && $file_name !~ m|/$|) {
|
||||
$title .= "/";
|
||||
}
|
||||
|
||||
return $title;
|
||||
}
|
||||
|
||||
sub git_header_html {
|
||||
my $status = shift || "200 OK";
|
||||
my $expires = shift;
|
||||
my %opts = @_;
|
||||
|
||||
my $title = "$site_name";
|
||||
if (defined $project) {
|
||||
$title .= " - " . to_utf8($project);
|
||||
if (defined $action) {
|
||||
$title .= "/$action";
|
||||
if (defined $file_name) {
|
||||
$title .= " - " . esc_path($file_name);
|
||||
if ($action eq "tree" && $file_name !~ m|/$|) {
|
||||
$title .= "/";
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
my $title = get_page_title();
|
||||
my $content_type;
|
||||
# require explicit support from the UA if we are to send the page as
|
||||
# 'application/xhtml+xml', otherwise send it as plain old 'text/html'.
|
||||
|
|
Loading…
Reference in a new issue