development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-11-05 01:58:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

t2021: do not negate test_path_is_dir

Browse source 
In this test, a path (some_dir) that is originally a directory is to
be removed and then to be replaced with a file of the same name.
The expectation is that the path becomes a file at the end.
However, "!  test_path_is_dir some_dir" is used to catch a breakage
that leaves the path as a directory.

But as with all the "test_path_is..." helpers, this use of the
helper makes it loud when the expectation (i.e. it is a directory)
is met, and otherwise is silent when it is not---this does not help
debugging.

Be more explicit and state that we expect the path to become a file.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2023-05-15 19:26:45 -07:00
parent c205923649
commit eab648d2b4
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
t/t2021-checkout-overwrite.sh
View file

@ -77,7 +77,7 @@ test_expect_success 'checkout --overwrite-ignore should succeed if only ignored
echo autogenerated information >some_dir/ignore && echo autogenerated information >some_dir/ignore &&
echo ignore >.git/info/exclude && echo ignore >.git/info/exclude &&
git checkout --overwrite-ignore df_conflict && git checkout --overwrite-ignore df_conflict &&
! test_path_is_dir some_dir test_path_is_file some_dir
' '
test_done test_done