mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
upload-pack: remove superfluous sigchain_pop() call
2997178ee6
(upload-pack: split check_unreachable() in two, prep for
get_reachable_list(), 2016-06-12) moved most code of has_unreachable()
into the new function do_reachable_revlist(). The latter takes care to
ignore SIGPIPE during its operations, and restores the original signal
handler before returning.
However, a sigchain_pop(SIGPIPE) call remained in the error handling
code of has_unreachable(), which does nothing because the stack is
empty after do_reachable_revlist() cleaned up after itself. Remove it.
Signed-off-by: René Scharfe <l.s.r@web.de>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
47ae905ffb
commit
e767963ab6
|
@ -731,7 +731,6 @@ static int has_unreachable(struct object_array *src, enum allow_uor allow_uor)
|
|||
return 0;
|
||||
|
||||
error:
|
||||
sigchain_pop(SIGPIPE);
|
||||
if (cmd.out >= 0)
|
||||
close(cmd.out);
|
||||
return 1;
|
||||
|
|
Loading…
Reference in a new issue