mirror of
https://github.com/git/git
synced 2024-10-30 04:01:21 +00:00
rev-parse: exit with non-zero status if ref@{n} is not valid.
"The current behaviour of ref@{...} syntax parser is suboptimal:
$ git rev-parse --verify jch@{99999} && echo true
warning: Log for 'jch' only has 1368 entries.
cfb88e9a8d
true
It even knows that it is running off the cut-off point; it should just
cause the caller to notice that fact. I don't think changing it to error
out should cause any harm to existing callers."
With this change:
$ git rev-parse --verify jch@{99999} || echo false
fatal: Log for 'jch' only has 1368 entries.
false
$ git rev-parse jch@{99999} || echo false
fatal: Log for 'jch' only has 1368 entries.
false
Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
64fdc08dac
commit
e6eedc31d5
1 changed files with 5 additions and 4 deletions
|
@ -430,10 +430,11 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
|
|||
"warning: Log for '%.*s' only goes "
|
||||
"back to %s.\n", len, str,
|
||||
show_date(co_time, co_tz, DATE_RFC2822));
|
||||
else
|
||||
fprintf(stderr,
|
||||
"warning: Log for '%.*s' only has "
|
||||
"%d entries.\n", len, str, co_cnt);
|
||||
else {
|
||||
free(real_ref);
|
||||
die("Log for '%.*s' only has %d entries.",
|
||||
len, str, co_cnt);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue