mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
gitweb.js: fix null object exception in initials calculation
Currently handleLine() assumes that a commit author name will always start with a capital letter. It's possible that the author name is user@example.com and therefore calling a match() on the name will fail to return any matches. Subsequently joining these matches will cause an exception. Fix by checking that we have a match before trying to join the results into a set of initials for the author. Signed-off-by: Stephen Boyd <bebarino@gmail.com> Acked-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
63267de2ac
commit
e42a05f75c
|
@ -566,8 +566,11 @@ function handleLine(commit, group) {
|
|||
if (group.numlines >= 2) {
|
||||
var fragment = document.createDocumentFragment();
|
||||
var br = document.createElement("br");
|
||||
var text = document.createTextNode(
|
||||
commit.author.match(/\b([A-Z])\B/g).join(''));
|
||||
var match = commit.author.match(/\b([A-Z])\B/g);
|
||||
if (match) {
|
||||
var text = document.createTextNode(
|
||||
match.join(''));
|
||||
}
|
||||
if (br && text) {
|
||||
var elem = fragment || td_sha1;
|
||||
elem.appendChild(br);
|
||||
|
|
Loading…
Reference in a new issue