mirror of
https://github.com/git/git
synced 2024-08-25 10:45:59 +00:00
fetch--tool: fix uninitialized buffer when reading from stdin
The original code allocates too much space and forgets to NUL terminate the string. Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
parent
dcf01c6e6b
commit
dec56c8cf1
|
@ -2,17 +2,24 @@
|
|||
#include "refs.h"
|
||||
#include "commit.h"
|
||||
|
||||
#define CHUNK_SIZE (1048576)
|
||||
#define CHUNK_SIZE 1024
|
||||
|
||||
static char *get_stdin(void)
|
||||
{
|
||||
int offset = 0;
|
||||
char *data = xmalloc(CHUNK_SIZE);
|
||||
int offset = 0, read = 0;
|
||||
read = xread(0, data, CHUNK_SIZE);
|
||||
while (read == CHUNK_SIZE) {
|
||||
offset += CHUNK_SIZE;
|
||||
|
||||
while (1) {
|
||||
int cnt = xread(0, data + offset, CHUNK_SIZE);
|
||||
if (cnt < 0)
|
||||
die("error reading standard input: %s",
|
||||
strerror(errno));
|
||||
if (cnt == 0) {
|
||||
data[offset] = 0;
|
||||
break;
|
||||
}
|
||||
offset += cnt;
|
||||
data = xrealloc(data, offset + CHUNK_SIZE);
|
||||
read = xread(0, data + offset, CHUNK_SIZE);
|
||||
}
|
||||
return data;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue