development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-27 11:39:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

remote-curl: consistently report repo url for http errors

Browse source 
When we report http errors in fetching the initial ref
advertisement, we show the full URL we attempted to use,
including "info/refs?service=git-upload-pack". While this
may be useful for debugging a broken server, it is
unnecessarily verbose and confusing for most cases, in which
the client user is not even the same person as the owner of
the repository.

Let's just show the repository URL; debugging can happen
with GIT_CURL_VERBOSE, which shows way more useful
information, anyway.

At the same time, let's also make sure to mention the
repository URL when we report failed authentication
(previously we said only "Authentication failed"). Knowing
the URL can help the user realize why authentication failed
(e.g., they meant to push to remote A, not remote B).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2013-04-05 18:21:14 -04:00 committed by Junio C Hamano
parent cfa0f4040d
commit d5ccbe4dfb
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
remote-curl.c
View file

@ -213,10 +213,10 @@ static struct discovery* discover_refs(const char *service, int for_push)
die("repository '%s' not found", url);
case HTTP_NOAUTH:
show_http_message(&type, &buffer);
die("Authentication failed");
die("Authentication failed for '%s'", url);
default:
show_http_message(&type, &buffer);
http_error(refs_url, http_ret);
http_error(url, http_ret);
die("HTTP request failed");
}