development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-02 14:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

reftable/block: use size_t to track restart point index

Browse source 
The function `block_reader_restart_offset()` gets the offset of the
`i`th restart point. `i` is a signed integer though, which is certainly
not the correct type to track indices like this. Furthermore, both
callers end up passing a `size_t`.

Refactor the code to use a `size_t` instead.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt 2024-05-13 10:47:01 +02:00 committed by Junio C Hamano
parent 0f3415f1f8
commit d537ce6b9e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
reftable/block.c
View file

@ -326,9 +326,9 @@ int block_reader_first_key(const struct block_reader *br, struct strbuf *key)
return 0; return 0;
} }
static uint32_t block_reader_restart_offset(const struct block_reader *br, int i) static uint32_t block_reader_restart_offset(const struct block_reader *br, size_t idx)
{ {
return get_be24(br->restart_bytes + 3 * i); return get_be24(br->restart_bytes + 3 * idx);
} }
void block_iter_seek_start(struct block_iter *it, const struct block_reader *br) void block_iter_seek_start(struct block_iter *it, const struct block_reader *br)