development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-01 06:05:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

t0024: avoid losing exit status to pipes

Browse source 
Replace pipe with redirection operator '>' to store the output
to a temporary file after 'git archive' command since the pipe
will swallow the command's exit code and a crash won't
necessarily be noticed.

Also fix an unwanted space after redirection '>' to match the
style described in CodingGuidelines.

Signed-off-by: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ghanshyam Thakkar 2024-01-19 09:03:34 +05:30 committed by Junio C Hamano
parent 186b115d30
commit d262bfa302
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
t/t0024-crlf-archive.sh
View file

@ -9,7 +9,7 @@ test_expect_success setup '
git config core.autocrlf true &&
printf "CRLF line ending\r\nAnd another\r\n" > sample &&
printf "CRLF line ending\r\nAnd another\r\n" >sample &&
git add sample &&
test_tick &&
@ -19,8 +19,8 @@ test_expect_success setup '
test_expect_success 'tar archive' '
git archive --format=tar HEAD |
( mkdir untarred && cd untarred && "$TAR" -xf - ) &&
git archive --format=tar HEAD >test.tar &&
( mkdir untarred && cd untarred && "$TAR" -xf ../test.tar ) &&
test_cmp sample untarred/sample