mirror of
https://github.com/git/git
synced 2024-08-28 12:09:19 +00:00
contrib/examples/git-fetch.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
a22c9e8d9e
commit
cc301d7e51
|
@ -146,13 +146,13 @@ esac
|
||||||
reflist=$(get_remote_refs_for_fetch "$@")
|
reflist=$(get_remote_refs_for_fetch "$@")
|
||||||
if test "$tags"
|
if test "$tags"
|
||||||
then
|
then
|
||||||
taglist=`IFS=' ' &&
|
taglist=$(IFS=' ' &&
|
||||||
echo "$ls_remote_result" |
|
echo "$ls_remote_result" |
|
||||||
git show-ref --exclude-existing=refs/tags/ |
|
git show-ref --exclude-existing=refs/tags/ |
|
||||||
while read sha1 name
|
while read sha1 name
|
||||||
do
|
do
|
||||||
echo ".${name}:${name}"
|
echo ".${name}:${name}"
|
||||||
done` || exit
|
done) || exit
|
||||||
if test "$#" -gt 1
|
if test "$#" -gt 1
|
||||||
then
|
then
|
||||||
# remote URL plus explicit refspecs; we need to merge them.
|
# remote URL plus explicit refspecs; we need to merge them.
|
||||||
|
|
Loading…
Reference in a new issue