development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-14 12:32:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

t/lib-gpg: avoid broken versions of ssh-keygen

Browse source 
The "-Y find-principals" option of ssh-keygen seems to be broken in
Debian's openssh-client 1:8.7p1-1, whereas it works fine in 1:8.4p1-5.
This causes several failures for GPGSSH tests. We fulfill the
prerequisite because generating the keys works fine, but actually
verifying a signature causes results ranging from bogus results to
ssh-keygen segfaulting.

We can find the broken version during the prereq check by feeding it
empty input. This should result in it complaining to stderr, but in the
broken version it triggers the segfault, causing the GPGSSH tests to be
skipped.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2021-11-10 01:00:47 -05:00 committed by Junio C Hamano
parent 65db97b4fa
commit ca7a5bf4bd
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
t/lib-gpg.sh
View file

@ -104,6 +104,12 @@ test_lazy_prereq GPGSSH '
test $? != 127 || exit 1
echo $ssh_version | grep -q "find-principals:missing signature file"
test $? = 0 || exit 1;
# some broken versions of ssh-keygen segfault on find-principals;
# avoid testing with them.
ssh-keygen -Y find-principals -f /dev/null -s /dev/null
test $? = 139 && exit 1
mkdir -p "${GNUPGHOME}" &&
chmod 0700 "${GNUPGHOME}" &&
ssh-keygen -t ed25519 -N "" -C "git ed25519 key" -f "${GPGSSH_KEY_PRIMARY}" >/dev/null &&