mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
tests: verify that clone -c core.hooksPath=/dev/null
works again
As part of the protections added in Git v2.45.1 and friends, repository-local `core.hooksPath` settings are no longer allowed, as a defense-in-depth mechanism to prevent future Git vulnerabilities to raise to critical level if those vulnerabilities inadvertently allow the repository-local config to be written. What the added protection did not anticipate is that such a repository-local `core.hooksPath` can not only be used to point to maliciously-placed scripts in the current worktree, but also to _prevent_ hooks from being called altogether. We just reverted the `core.hooksPath` protections, based on the Git maintainer's recommendation in https://lore.kernel.org/git/xmqq4jaxvm8z.fsf@gitster.g/ to address this concern as well as related ones. Let's make sure that we won't regress while trying to protect the clone operation further. Reported-by: Brooke Kuhlmann <brooke@alchemists.io> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
75631a3cd8
commit
c8f64781c8
|
@ -41,4 +41,11 @@ test_expect_success 'git rev-parse --git-path hooks' '
|
|||
test .git/custom-hooks/abc = "$(cat actual)"
|
||||
'
|
||||
|
||||
test_expect_success 'core.hooksPath=/dev/null' '
|
||||
git clone -c core.hooksPath=/dev/null . no-templates &&
|
||||
value="$(git -C no-templates config --local core.hooksPath)" &&
|
||||
# The Bash used by Git for Windows rewrites `/dev/null` to `nul`
|
||||
{ test /dev/null = "$value" || test nul = "$value"; }
|
||||
'
|
||||
|
||||
test_done
|
||||
|
|
Loading…
Reference in a new issue