mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
t9001: avoid including non-trailing NUL bytes in variables
In this test, we have a command substitution whose output starts with a NUL byte. bash and dash strip out any NUL bytes from the output; zsh does not. As a consequence, zsh fails this test, since the command line argument we use the variable in is truncated by the NUL byte. POSIX says of a command substitution that if "the output contains any null bytes, the behavior is unspecified," so all of the shells are in compliance with POSIX. To make our code more portable, let's avoid prefacing our variables with NUL bytes and instead leave only the trailing one behind. Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
5fa0f5238b
commit
c64368e3a2
1 changed files with 1 additions and 1 deletions
|
@ -2066,7 +2066,7 @@ test_expect_success $PREREQ 'leading and trailing whitespaces are removed' '
|
||||||
TO1=$(echo "QTo 1 <to1@example.com>" | q_to_tab) &&
|
TO1=$(echo "QTo 1 <to1@example.com>" | q_to_tab) &&
|
||||||
TO2=$(echo "QZto2" | qz_to_tab_space) &&
|
TO2=$(echo "QZto2" | qz_to_tab_space) &&
|
||||||
CC1=$(echo "cc1" | append_cr) &&
|
CC1=$(echo "cc1" | append_cr) &&
|
||||||
BCC1=$(echo "Q bcc1@example.com Q" | q_to_nul) &&
|
BCC1=$(echo " bcc1@example.com Q" | q_to_nul) &&
|
||||||
git send-email \
|
git send-email \
|
||||||
--dry-run \
|
--dry-run \
|
||||||
--from=" Example <from@example.com>" \
|
--from=" Example <from@example.com>" \
|
||||||
|
|
Loading…
Reference in a new issue