mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
t/t5550-http-fetch-dumb.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
752f505cf3
commit
bacb1c016d
|
@ -132,7 +132,7 @@ test_expect_success 'fetch packed objects' '
|
||||||
test_expect_success 'fetch notices corrupt pack' '
|
test_expect_success 'fetch notices corrupt pack' '
|
||||||
cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/repo_pack.git "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad1.git &&
|
cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/repo_pack.git "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad1.git &&
|
||||||
(cd "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad1.git &&
|
(cd "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad1.git &&
|
||||||
p=`ls objects/pack/pack-*.pack` &&
|
p=$(ls objects/pack/pack-*.pack) &&
|
||||||
chmod u+w $p &&
|
chmod u+w $p &&
|
||||||
printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc
|
printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc
|
||||||
) &&
|
) &&
|
||||||
|
@ -140,14 +140,14 @@ test_expect_success 'fetch notices corrupt pack' '
|
||||||
(cd repo_bad1.git &&
|
(cd repo_bad1.git &&
|
||||||
git --bare init &&
|
git --bare init &&
|
||||||
test_must_fail git --bare fetch $HTTPD_URL/dumb/repo_bad1.git &&
|
test_must_fail git --bare fetch $HTTPD_URL/dumb/repo_bad1.git &&
|
||||||
test 0 = `ls objects/pack/pack-*.pack | wc -l`
|
test 0 = $(ls objects/pack/pack-*.pack | wc -l)
|
||||||
)
|
)
|
||||||
'
|
'
|
||||||
|
|
||||||
test_expect_success 'fetch notices corrupt idx' '
|
test_expect_success 'fetch notices corrupt idx' '
|
||||||
cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/repo_pack.git "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad2.git &&
|
cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/repo_pack.git "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad2.git &&
|
||||||
(cd "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad2.git &&
|
(cd "$HTTPD_DOCUMENT_ROOT_PATH"/repo_bad2.git &&
|
||||||
p=`ls objects/pack/pack-*.idx` &&
|
p=$(ls objects/pack/pack-*.idx) &&
|
||||||
chmod u+w $p &&
|
chmod u+w $p &&
|
||||||
printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc
|
printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc
|
||||||
) &&
|
) &&
|
||||||
|
@ -155,7 +155,7 @@ test_expect_success 'fetch notices corrupt idx' '
|
||||||
(cd repo_bad2.git &&
|
(cd repo_bad2.git &&
|
||||||
git --bare init &&
|
git --bare init &&
|
||||||
test_must_fail git --bare fetch $HTTPD_URL/dumb/repo_bad2.git &&
|
test_must_fail git --bare fetch $HTTPD_URL/dumb/repo_bad2.git &&
|
||||||
test 0 = `ls objects/pack | wc -l`
|
test 0 = $(ls objects/pack | wc -l)
|
||||||
)
|
)
|
||||||
'
|
'
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue