development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-02 14:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

notes.c: append separator instead of insert by pos

Browse source 
Rename "insert_separator" to "append_separator" and also remove the
"postion" argument, this serves two purpose:

The first is that when specifying more than one "-m" ( like "-F", etc)
to "git notes add" or "git notes append", the order of them matters,
which means we need to append the each separator and message in turn,
so we don't have to make the caller specify the position, the "append"
operation is enough and clear.

The second is that when we execute the "git notes append" subcommand,
we need to combine the "prev_note" and "current_note" to get the
final result. Before, we inserted a newline character at the beginning
of "current_note". Now, we will append a newline to the end of
"prev_note" instead, this will give the consisitent results.

Signed-off-by: Teng Long <dyroneteng@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Teng Long 2023-05-27 15:57:52 +08:00 committed by Junio C Hamano
parent 90bc19b3ae
commit b7d87ad537
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
builtin/notes.c
View file

@ -229,13 +229,13 @@ static void write_note_data(struct note_data *d, struct object_id *oid)
}
}
static void insert_separator(struct strbuf *message, size_t pos)
static void append_separator(struct strbuf *message)
{
size_t sep_len = strlen(separator);
if (sep_len && separator[sep_len - 1] == '\n')
strbuf_insertstr(message, pos, separator);
strbuf_addstr(message, separator);
else
strbuf_insertf(message, pos, "%s%s", separator, "\n");
strbuf_addf(message, "%s%s", separator, "\n");
}
static void concat_messages(struct note_data *d)
@ -245,7 +245,7 @@ static void concat_messages(struct note_data *d)
size_t i;
for (i = 0; i < d->msg_nr ; i++) {
if (d->buf.len)
insert_separator(&d->buf, d->buf.len);
append_separator(&d->buf);
strbuf_add(&msg, d->messages[i]->buf.buf, d->messages[i]->buf.len);
strbuf_addbuf(&d->buf, &msg);
if (d->messages[i]->stripspace)
@ -680,14 +680,17 @@ static int append_edit(int argc, const char **argv, const char *prefix)
/* Append buf to previous note contents */
unsigned long size;
enum object_type type;
char *prev_buf = repo_read_object_file(the_repository, note,
&type, &size);
struct strbuf buf = STRBUF_INIT;
char *prev_buf = repo_read_object_file(the_repository, note, &type, &size);
if (d.buf.len && prev_buf && size)
insert_separator(&d.buf, 0);
if (prev_buf && size)
strbuf_insert(&d.buf, 0, prev_buf, size);
strbuf_add(&buf, prev_buf, size);
if (d.buf.len && prev_buf && size)
append_separator(&buf);
strbuf_insert(&d.buf, 0, buf.buf, buf.len);
free(prev_buf);
strbuf_release(&buf);
}
if (d.buf.len || allow_empty) {