development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-12 11:32:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

gc: simplify maintenance_task_pack_refs()

Browse source 
Pass a constant string array directly to run_command_v_opt() instead of
copying it into a strvec first.  This shortens the code and avoids heap
allocations.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2022-10-04 18:17:39 +02:00 committed by Junio C Hamano
parent 3dcec76d9d
commit b004c90282
1 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
builtin/gc.c
View file

@ -167,16 +167,9 @@ static void gc_config(void)
struct maintenance_run_opts;
static int maintenance_task_pack_refs(MAYBE_UNUSED struct maintenance_run_opts *opts)
{
struct strvec pack_refs_cmd = STRVEC_INIT;
int ret;
const char *argv[] = { "pack-refs", "--all", "--prune", NULL };
strvec_pushl(&pack_refs_cmd, "pack-refs", "--all", "--prune", NULL);
ret = run_command_v_opt(pack_refs_cmd.v, RUN_GIT_CMD);
strvec_clear(&pack_refs_cmd);
return ret;
return run_command_v_opt(argv, RUN_GIT_CMD);
}
static int too_many_loose_objects(void)