development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-27 03:29:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

git-verify-pack: more careful path handling

Browse source 
Use strlcpy() to copy the filename into a buffer and complain if it
doesn't fit.  Also move the path buffer into verify_one_pack(); it is
used only there.  Now we can const'ify the first argument of this
function.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Rene Scharfe 2006-08-10 17:02:32 +02:00 committed by Junio C Hamano
parent 6f05b57da8
commit ae9c86f2b6
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
verify-pack.c
View file

@ -1,11 +1,16 @@
#include "cache.h"
#include "pack.h"
static int verify_one_pack(char *arg, int verbose)
static int verify_one_pack(const char *path, int verbose)
{
int len = strlen(arg);
char arg[PATH_MAX];
int len;
struct packed_git *g;
len = strlcpy(arg, path, PATH_MAX);
if (len >= PATH_MAX)
return error("name too long: %s", path);
while (1) {
/* Should name foo.idx, but foo.pack may be named;
* convert it to foo.idx
@ -37,8 +42,6 @@ int main(int ac, char **av)
int nothing_done = 1;
while (1 < ac) {
char path[PATH_MAX];
if (!no_more_options && av[1][0] == '-') {
if (!strcmp("-v", av[1]))
verbose = 1;
@ -48,8 +51,7 @@ int main(int ac, char **av)
usage(verify_pack_usage);
}
else {
strcpy(path, av[1]);
if (verify_one_pack(path, verbose))
if (verify_one_pack(av[1], verbose))
errs++;
nothing_done = 0;
}