mirror of
https://github.com/git/git
synced 2024-08-28 12:09:19 +00:00
cocci: simplify check for trivial format strings
353d84c537
(coccicheck: make transformation for strbuf_addf(sb, "...")
more precise) added a check to avoid transforming calls with format
strings which contain percent signs, as that would change the result.
It uses embedded Python code for that. Simplify this rule by using the
regular expression matching operator instead.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
8279ed033f
commit
ae239fc8e5
|
@ -1,21 +1,6 @@
|
|||
@ strbuf_addf_with_format_only @
|
||||
expression E;
|
||||
constant fmt;
|
||||
@@
|
||||
strbuf_addf(E,
|
||||
(
|
||||
fmt
|
||||
|
|
||||
_(fmt)
|
||||
)
|
||||
);
|
||||
|
||||
@ script:python @
|
||||
fmt << strbuf_addf_with_format_only.fmt;
|
||||
@@
|
||||
cocci.include_match("%" not in fmt)
|
||||
|
||||
@ extends strbuf_addf_with_format_only @
|
||||
constant fmt !~ "%";
|
||||
@@
|
||||
- strbuf_addf
|
||||
+ strbuf_addstr
|
||||
|
|
Loading…
Reference in a new issue