commit_ref_update(): new function, extracted from write_ref_sha1()

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2015-05-09 17:18:36 +02:00 committed by Junio C Hamano
parent e6fd3c6730
commit ad4cd6c297

27
refs.c
View file

@ -3059,15 +3059,13 @@ static int write_ref_to_lockfile(struct ref_lock *lock,
}
/*
* Write sha1 into the ref specified by the lock. Make sure that errno
* is sane on error.
* Commit a change to a loose reference that has already been written
* to the loose reference lockfile. Also update the reflogs if
* necessary, using the specified lockmsg (which can be NULL).
*/
static int write_ref_sha1(struct ref_lock *lock,
const unsigned char *sha1, const char *logmsg)
static int commit_ref_update(struct ref_lock *lock,
const unsigned char *sha1, const char *logmsg)
{
if (write_ref_to_lockfile(lock, sha1))
return -1;
clear_loose_ref_cache(&ref_cache);
if (log_ref_write(lock->ref_name, lock->old_sha1, sha1, logmsg) < 0 ||
(strcmp(lock->ref_name, lock->orig_ref_name) &&
@ -3106,6 +3104,21 @@ static int write_ref_sha1(struct ref_lock *lock,
return 0;
}
/*
* Write sha1 as the new value of the reference specified by the
* (open) lock. On error, roll back the lockfile and set errno
* appropriately.
*/
static int write_ref_sha1(struct ref_lock *lock,
const unsigned char *sha1, const char *logmsg)
{
if (write_ref_to_lockfile(lock, sha1) ||
commit_ref_update(lock, sha1, logmsg))
return -1;
return 0;
}
int create_symref(const char *ref_target, const char *refs_heads_master,
const char *logmsg)
{