mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
blame: drop strdup of string literal
This strdup was added as part of58dbfa2
(blame: accept multiple -L ranges, 2013-08-06) to be consistent with parse_opt_string_list(), which appends to the same list. But as of7a7a517
(parse_opt_string_list: stop allocating new strings, 2016-06-13), we should stop using strdup (to match parse_opt_string_list, and for all the reasons described in that commit; namely that it does nothing useful and causes us to leak the memory). Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
64093fc06a
commit
aa59e14b23
|
@ -2748,7 +2748,7 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
|
|||
lno = prepare_lines(&sb);
|
||||
|
||||
if (lno && !range_list.nr)
|
||||
string_list_append(&range_list, xstrdup("1"));
|
||||
string_list_append(&range_list, "1");
|
||||
|
||||
anchor = 1;
|
||||
range_set_init(&ranges, range_list.nr);
|
||||
|
|
Loading…
Reference in a new issue