mirror of
https://github.com/git/git
synced 2024-08-28 20:20:07 +00:00
Merge branch 'ds/for-each-repo-noopfix'
"git for-each-repo --config=<var> <cmd>" should not run <cmd> for any repository when the configuration variable <var> is not defined even once. * ds/for-each-repo-noopfix: for-each-repo: do nothing on empty config
This commit is contained in:
commit
aa08688362
|
@ -51,6 +51,13 @@ int cmd_for_each_repo(int argc, const char **argv, const char *prefix)
|
||||||
values = repo_config_get_value_multi(the_repository,
|
values = repo_config_get_value_multi(the_repository,
|
||||||
config_key);
|
config_key);
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Do nothing on an empty list, which is equivalent to the case
|
||||||
|
* where the config variable does not exist at all.
|
||||||
|
*/
|
||||||
|
if (!values)
|
||||||
|
return 0;
|
||||||
|
|
||||||
for (i = 0; !result && i < values->nr; i++)
|
for (i = 0; !result && i < values->nr; i++)
|
||||||
result = run_command_on_repo(values->items[i].string, &args);
|
result = run_command_on_repo(values->items[i].string, &args);
|
||||||
|
|
||||||
|
|
|
@ -27,4 +27,10 @@ test_expect_success 'run based on configured value' '
|
||||||
grep again message
|
grep again message
|
||||||
'
|
'
|
||||||
|
|
||||||
|
test_expect_success 'do nothing on empty config' '
|
||||||
|
# the whole thing would fail if for-each-ref iterated even
|
||||||
|
# once, because "git help --no-such-option" would fail
|
||||||
|
git for-each-repo --config=bogus.config -- help --no-such-option
|
||||||
|
'
|
||||||
|
|
||||||
test_done
|
test_done
|
||||||
|
|
Loading…
Reference in a new issue