development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-02 14:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

replay: die() instead of failing assert()

Browse source 
It's not a good idea for regular Git commands to use an assert() to
check for things that could happen but are not supported.

Let's die() with an explanation of the issue instead.

Co-authored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elijah Newren 2023-11-24 12:10:33 +01:00 committed by Junio C Hamano
parent d46da6d90b
commit a9df61ace3
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
builtin/replay.c
View file

@ -179,7 +179,12 @@ int cmd_replay(int argc, const char **argv, const char *prefix)
fprintf(stderr, "Rebasing %s...\r", fprintf(stderr, "Rebasing %s...\r",
oid_to_hex(&commit->object.oid)); oid_to_hex(&commit->object.oid));
assert(commit->parents && !commit->parents->next);
if (!commit->parents)
die(_("replaying down to root commit is not supported yet!"));
if (commit->parents->next)
die(_("replaying merge commits is not supported yet!"));
base = commit->parents->item; base = commit->parents->item;
next_tree = repo_get_commit_tree(the_repository, commit); next_tree = repo_get_commit_tree(the_repository, commit);