mirror of
https://github.com/git/git
synced 2024-08-27 03:29:21 +00:00
t3001, t7300: add testcase showcasing missed directory traversal
In the last commit, we added a testcase showing that the directory traversal machinery sometimes traverses into directories unnecessarily. Here we show that there are cases where it does the opposite: it does not traverse into directories, despite those directories having important files that need to be flagged. Add a testcase showing that `git ls-files -o -i --directory` can omit some of the files it should be listing, and another showing that `git clean -fX` can fail to clean out some of the expected files. Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
2e4e43a691
commit
a97c7a8bc4
|
@ -292,6 +292,11 @@ EOF
|
||||||
test_cmp expect actual
|
test_cmp expect actual
|
||||||
'
|
'
|
||||||
|
|
||||||
|
test_expect_failure 'ls-files with "**" patterns and --directory' '
|
||||||
|
# Expectation same as previous test
|
||||||
|
git ls-files --directory -o -i --exclude "**/a.1" >actual &&
|
||||||
|
test_cmp expect actual
|
||||||
|
'
|
||||||
|
|
||||||
test_expect_success 'ls-files with "**" patterns and no slashes' '
|
test_expect_success 'ls-files with "**" patterns and no slashes' '
|
||||||
git ls-files -o -i --exclude "one**a.1" >actual &&
|
git ls-files -o -i --exclude "one**a.1" >actual &&
|
||||||
|
|
|
@ -769,4 +769,23 @@ test_expect_failure 'avoid traversing into ignored directories' '
|
||||||
test_cmp trace.expect trace.relevant
|
test_cmp trace.expect trace.relevant
|
||||||
'
|
'
|
||||||
|
|
||||||
|
test_expect_failure 'traverse into directories that may have ignored entries' '
|
||||||
|
test_when_finished rm -f output &&
|
||||||
|
test_create_repo need-to-traverse-into-hierarchy &&
|
||||||
|
(
|
||||||
|
cd need-to-traverse-into-hierarchy &&
|
||||||
|
mkdir -p modules/foobar/src/generated &&
|
||||||
|
> modules/foobar/src/generated/code.c &&
|
||||||
|
> modules/foobar/Makefile &&
|
||||||
|
echo "/modules/**/src/generated/" >.gitignore &&
|
||||||
|
|
||||||
|
git clean -fX modules/foobar >../output &&
|
||||||
|
|
||||||
|
grep Removing ../output &&
|
||||||
|
|
||||||
|
test_path_is_missing modules/foobar/src/generated/code.c &&
|
||||||
|
test_path_is_file modules/foobar/Makefile
|
||||||
|
)
|
||||||
|
'
|
||||||
|
|
||||||
test_done
|
test_done
|
||||||
|
|
Loading…
Reference in a new issue