mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
revert: Don't check lone argument in get_encoding
The only place get_encoding uses the global "commit" variable is when writing an error message explaining that its lone argument was NULL. Since the function's only caller ensures that a NULL argument isn't passed, we can remove this check with two beneficial consequences: 1. Since the function doesn't use the global "commit" variable any more, it won't need to change when we eliminate the global variable later in the series. 2. Translators no longer need to localize an error message that will never be shown. Suggested-by: Junio C Hamano <gitster@pobox.com> Mentored-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
be33c46cda
commit
a2ec3ad28f
|
@ -167,9 +167,6 @@ static char *get_encoding(const char *message)
|
|||
{
|
||||
const char *p = message, *eol;
|
||||
|
||||
if (!p)
|
||||
die (_("Could not read commit message of %s"),
|
||||
sha1_to_hex(commit->object.sha1));
|
||||
while (*p && *p != '\n') {
|
||||
for (eol = p + 1; *eol && *eol != '\n'; eol++)
|
||||
; /* do nothing */
|
||||
|
|
Loading…
Reference in a new issue