mirror of
https://github.com/git/git
synced 2024-08-28 20:20:07 +00:00
mv: allow moving nested submodules
When directories are moved using `git mv` all files in the directory have been just moved, but no further action was taken on them. This was done by assigning the mode = WORKING_DIRECTORY to the files inside a moved directory. submodules however need to update their link to the git directory as well as updates to the .gitmodules file. By removing the condition of `mode != INDEX` (the remaining modes are BOTH and WORKING_DIRECTORY) for the required submodule actions, we perform these for submodules in a moved directory. Signed-off-by: Stefan Beller <sbeller@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
e46579643d
commit
a127331cd8
21
builtin/mv.c
21
builtin/mv.c
|
@ -251,15 +251,18 @@ int cmd_mv(int argc, const char **argv, const char *prefix)
|
|||
int pos;
|
||||
if (show_only || verbose)
|
||||
printf(_("Renaming %s to %s\n"), src, dst);
|
||||
if (!show_only && mode != INDEX) {
|
||||
if (rename(src, dst) < 0 && !ignore_errors)
|
||||
die_errno(_("renaming '%s' failed"), src);
|
||||
if (submodule_gitfile[i]) {
|
||||
if (submodule_gitfile[i] != SUBMODULE_WITH_GITDIR)
|
||||
connect_work_tree_and_git_dir(dst, submodule_gitfile[i]);
|
||||
if (!update_path_in_gitmodules(src, dst))
|
||||
gitmodules_modified = 1;
|
||||
}
|
||||
if (show_only)
|
||||
continue;
|
||||
if (mode != INDEX && rename(src, dst) < 0) {
|
||||
if (ignore_errors)
|
||||
continue;
|
||||
die_errno(_("renaming '%s' failed"), src);
|
||||
}
|
||||
if (submodule_gitfile[i]) {
|
||||
if (submodule_gitfile[i] != SUBMODULE_WITH_GITDIR)
|
||||
connect_work_tree_and_git_dir(dst, submodule_gitfile[i]);
|
||||
if (!update_path_in_gitmodules(src, dst))
|
||||
gitmodules_modified = 1;
|
||||
}
|
||||
|
||||
if (mode == WORKING_DIRECTORY)
|
||||
|
|
|
@ -292,6 +292,9 @@ test_expect_success 'setup submodule' '
|
|||
echo content >file &&
|
||||
git add file &&
|
||||
git commit -m "added sub and file" &&
|
||||
mkdir -p deep/directory/hierachy &&
|
||||
git submodule add ./. deep/directory/hierachy/sub &&
|
||||
git commit -m "added another submodule" &&
|
||||
git branch submodule
|
||||
'
|
||||
|
||||
|
@ -475,4 +478,17 @@ test_expect_success 'mv -k does not accidentally destroy submodules' '
|
|||
git checkout .
|
||||
'
|
||||
|
||||
test_expect_success 'moving a submodule in nested directories' '
|
||||
(
|
||||
cd deep &&
|
||||
git mv directory ../ &&
|
||||
# git status would fail if the update of linking git dir to
|
||||
# work dir of the submodule failed.
|
||||
git status &&
|
||||
git config -f ../.gitmodules submodule.deep/directory/hierachy/sub.path >../actual &&
|
||||
echo "directory/hierachy/sub" >../expect
|
||||
) &&
|
||||
test_cmp actual expect
|
||||
'
|
||||
|
||||
test_done
|
||||
|
|
Loading…
Reference in a new issue