mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
http-push: prevent format overflow warning with gcc >= 9
In function 'finish_request', inlined from 'process_response' at http-push.c:248:2: http-push.c:587:4: warning: '%s' directive argument is null [-Wformat-overflow=] 587 | fprintf(stderr, "Unable to get pack file %s\n%s", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 588 | request->url, curl_errorstr); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ request->url is needed for the error message if there was a failure during fetch but was being cleared unnecessarily earlier. note that the leak is prevented by calling release_request unconditionally at the end. Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> Suggested-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
aeb582a983
commit
9dde06de13
|
@ -525,8 +525,8 @@ static void finish_request(struct transfer_request *request)
|
||||||
if (request->headers != NULL)
|
if (request->headers != NULL)
|
||||||
curl_slist_free_all(request->headers);
|
curl_slist_free_all(request->headers);
|
||||||
|
|
||||||
/* URL is reused for MOVE after PUT */
|
/* URL is reused for MOVE after PUT and used during FETCH */
|
||||||
if (request->state != RUN_PUT) {
|
if (request->state != RUN_PUT && request->state != RUN_FETCH_PACKED) {
|
||||||
FREE_AND_NULL(request->url);
|
FREE_AND_NULL(request->url);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue