development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-28 12:09:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

apply: free unused fragments for submodule patch

Browse source 
We simply discarded the fragments that we are not going to use upon seeing
a patch to update the submodule commit bound at path that we have not
checked out.

Free these fragments, not to leak them.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2012-03-28 23:22:22 -07:00
parent 8192a2fafc
commit 9d16c2d514
1 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
builtin/apply.c
View file

@ -196,17 +196,20 @@ struct patch {
struct patch *next;
};
static void free_fragment_list(struct fragment *list)
{
while (list) {
struct fragment *next = list->next;
if (list->free_patch)
free((char *)list->patch);
free(list);
list = next;
}
}
static void free_patch(struct patch *patch)
{
struct fragment *fragment = patch->fragments;
while (fragment) {
struct fragment *fragment_next = fragment->next;
if (fragment->patch != NULL && fragment->free_patch)
free((char *)fragment->patch);
free(fragment);
fragment = fragment_next;
}
free_fragment_list(patch->fragments);
free(patch->def_name);
free(patch->old_name);
free(patch->new_name);
@ -2992,7 +2995,10 @@ static int apply_data(struct patch *patch, struct stat *st, struct cache_entry *
/*
* There is no way to apply subproject
* patch without looking at the index.
* NEEDSWORK: shouldn't this be flagged
* as an error???
*/
free_fragment_list(patch->fragments);
patch->fragments = NULL;
}
} else {