mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
test-tool bloom: fix memory leaks
Fix memory leaks introduced with these tests in f1294eaf7f
(bloom.c:
introduce core Bloom filter constructs, 2020-03-30), as a result we
can mark almost the entirety of t0095-bloom.sh as passing with
SANITIZE=leak using "TEST_PASSES_SANITIZE_LEAK=true", there's still an
unrelated memory leak in "git commit" in one of the tests, let's skip
that one under SANITIZE_LEAK for now.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
1caaa858cc
commit
9794633b4e
|
@ -16,6 +16,7 @@ static void add_string_to_filter(const char *data, struct bloom_filter *filter)
|
|||
}
|
||||
printf("\n");
|
||||
add_key_to_filter(&key, filter, &settings);
|
||||
clear_bloom_key(&key);
|
||||
}
|
||||
|
||||
static void print_bloom_filter(struct bloom_filter *filter) {
|
||||
|
@ -80,6 +81,7 @@ int cmd__bloom(int argc, const char **argv)
|
|||
}
|
||||
|
||||
print_bloom_filter(&filter);
|
||||
free(filter.data);
|
||||
}
|
||||
|
||||
if (!strcmp(argv[1], "get_filter_for_commit")) {
|
||||
|
|
|
@ -67,7 +67,7 @@ test_expect_success 'compute bloom key for test string 2' '
|
|||
test_cmp expect actual
|
||||
'
|
||||
|
||||
test_expect_success 'get bloom filters for commit with no changes' '
|
||||
test_expect_success !SANITIZE_LEAK 'get bloom filters for commit with no changes' '
|
||||
git init &&
|
||||
git commit --allow-empty -m "c0" &&
|
||||
cat >expect <<-\EOF &&
|
||||
|
|
Loading…
Reference in a new issue