mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
hash-object: prefix_filename() returns allocated memory these days
Back whena1be47e4
(hash-object: fix buffer reuse with --path in a subdirectory, 2017-03-20) was written, the prefix_filename() helper used a static piece of memory to the caller, making the caller responsible for copying it, if it wants to keep it across another call to the same function. Two callers of the prefix_filename() in hash-object were made to xstrdup() the value obtained from it. But in the same series, whene4da43b1
(prefix_filename: return newly allocated string, 2017-03-20) changed the rule to gave the caller possession of the memory, we forgot to revert one of the xstrdup() changes, allowing the returned value to leak. Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
225bc32a98
commit
92a5d1c9b4
|
@ -117,7 +117,7 @@ int cmd_hash_object(int argc, const char **argv, const char *prefix)
|
|||
prefix = setup_git_directory_gently(&nongit);
|
||||
|
||||
if (vpath && prefix)
|
||||
vpath = xstrdup(prefix_filename(prefix, vpath));
|
||||
vpath = prefix_filename(prefix, vpath);
|
||||
|
||||
git_config(git_default_config, NULL);
|
||||
|
||||
|
|
Loading…
Reference in a new issue