development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-25 02:35:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

t/chainlint: add chainlint "one-liner" test cases

Browse source 
The --chain-lint option uses heuristics and knowledge of shell syntax to
detect broken &&-chains in subshells by pure textual inspection. The
heuristics handle a range of stylistic variations in existing tests
(evolved over the years), however, they are still best-guesses. As such,
it is possible for future changes to accidentally break assumptions upon
which the heuristics are based. Protect against this possibility by
adding tests which check the linter itself for correctness.

In addition to protecting against regressions, these tests help document
(for humans) expected behavior, which is important since the linter's
implementation language ('sed') does not necessarily lend itself to easy
comprehension.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Eric Sunshine 2018-07-11 02:46:37 -04:00 committed by Junio C Hamano
parent 7b90679012
commit 90a880393a
6 changed files with 71 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
t/chainlint/negated-one-liner.expect Normal file
View file

@ -0,0 +1,5 @@
! (foo && bar) &&
! (foo && bar) >baz &&
?!SEMI?!! (foo; bar) &&
?!SEMI?!! (foo; bar) >baz

7
t/chainlint/negated-one-liner.test Normal file
View file

@ -0,0 +1,7 @@
# LINT: top-level one-liner subshell
! (foo && bar) &&
! (foo && bar) >baz &&
# LINT: top-level one-liner subshell missing internal "&&"
! (foo; bar) &&
! (foo; bar) >baz

9
t/chainlint/one-liner.expect Normal file
View file

@ -0,0 +1,9 @@
(foo && bar) &&
(foo && bar) |
(foo && bar) >baz &&
?!SEMI?!(foo; bar) &&
?!SEMI?!(foo; bar) |
?!SEMI?!(foo; bar) >baz
(foo "bar; baz")

12
t/chainlint/one-liner.test Normal file
View file

@ -0,0 +1,12 @@
# LINT: top-level one-liner subshell
(foo && bar) &&
(foo && bar) |
(foo && bar) >baz &&
# LINT: top-level one-liner subshell missing internal "&&"
(foo; bar) &&
(foo; bar) |
(foo; bar) >baz
# LINT: ";" in string not misinterpreted as broken &&-chain
(foo "bar; baz")

14
t/chainlint/subshell-one-liner.expect Normal file
View file

@ -0,0 +1,14 @@
(
(foo && bar) &&
(foo && bar) |
(foo && bar) >baz &&
?!SEMI?! (foo; bar) &&
?!SEMI?! (foo; bar) |
?!SEMI?! (foo; bar) >baz &&
(foo || exit 1) &&
(foo || exit 1) |
(foo || exit 1) >baz &&
?!AMP?! (foo && bar)
?!AMP?!?!SEMI?! (foo && bar; baz)
foobar
>)

24
t/chainlint/subshell-one-liner.test Normal file
View file

@ -0,0 +1,24 @@
(
# LINT: nested one-liner subshell
(foo && bar) &&
(foo && bar) |
(foo && bar) >baz &&
# LINT: nested one-liner subshell missing internal "&&"
(foo; bar) &&
(foo; bar) |
(foo; bar) >baz &&
# LINT: nested one-liner subshell with "|| exit"
(foo || exit 1) &&
(foo || exit 1) |
(foo || exit 1) >baz &&
# LINT: nested one-liner subshell lacking ending "&&"
(foo && bar)
# LINT: nested one-liner subshell missing internal "&&" and lacking ending "&&"
(foo && bar; baz)
foobar
)