development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-30 04:01:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

t0010-racy-git.sh: use the $( ... ) construct for command substitution

Browse source 
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto 2014-04-28 05:57:25 -07:00 committed by Junio C Hamano
parent 88619b3ee4
commit 8fc5593c53
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
t/t0010-racy-git.sh
View file

@ -14,7 +14,7 @@ do
git update-index --add infocom git update-index --add infocom
echo xyzzy >infocom echo xyzzy >infocom
files=`git diff-files -p` files=$(git diff-files -p)
test_expect_success \ test_expect_success \
"Racy GIT trial #$trial part A" \ "Racy GIT trial #$trial part A" \
'test "" != "$files"' 'test "" != "$files"'
@ -23,7 +23,7 @@ do
echo xyzzy >cornerstone echo xyzzy >cornerstone
git update-index --add cornerstone git update-index --add cornerstone
files=`git diff-files -p` files=$(git diff-files -p)
test_expect_success \ test_expect_success \
"Racy GIT trial #$trial part B" \ "Racy GIT trial #$trial part B" \
'test "" != "$files"' 'test "" != "$files"'